hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 16146: HIVE-5993: JDBC Driver should not hard-code the database name
Date Thu, 12 Dec 2013 07:37:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16146/#review30246
-----------------------------------------------------------

Ship it!


Thanks for addressing the feedback.
Looks fine to me.

- Prasad Mujumdar


On Dec. 11, 2013, 10:33 p.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16146/
> -----------------------------------------------------------
> 
> (Updated Dec. 11, 2013, 10:33 p.m.)
> 
> 
> Review request for hive and Prasad Mujumdar.
> 
> 
> Bugs: HIVE-5993
>     https://issues.apache.org/jira/browse/HIVE-5993
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Method HiveDatabaseMetadata.getDatabaseProductName() returns a hard-coded string "Hive".
> 
> This should instead call the existing Hive-server2 api to return the db name.  Incidentally,
the server returns "Apache Hive".
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 1ba8ad3 
>   jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java 5087ded 
> 
> Diff: https://reviews.apache.org/r/16146/diff/
> 
> 
> Testing
> -------
> 
> Ran TestJdbcDriver2.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message