hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Carl Steinbach" <...@apache.org>
Subject Re: Review Request 16063: HIVE-4395: Support TFetchOrientation.FIRST for HiveServer2 FetchResults
Date Fri, 06 Dec 2013 18:45:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16063/#review29893
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java
<https://reviews.apache.org/r/16063/#comment57360>

    Formatting.



service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
<https://reviews.apache.org/r/16063/#comment57361>

    Since this EnumSet if constant I think we should make it a static final class variable.
    
    Also, formatting.



service/src/java/org/apache/hive/service/cli/operation/Operation.java
<https://reviews.apache.org/r/16063/#comment57362>

    Use supportedOrientations.contains(orientation) instead of manually iterating through
the set. Also, should this method be protected instead of public?


- Carl Steinbach


On Dec. 6, 2013, 5:37 a.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16063/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2013, 5:37 a.m.)
> 
> 
> Review request for hive, Brock Noland and Thejas Nair.
> 
> 
> Bugs: HIVE-4395
>     https://issues.apache.org/jira/browse/HIVE-4395
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support fetch-from-start for hiveserver2 fetch operations. 
>  - Handle new fetch orientation for various HS2 operations.
>  - Added support to reset the read position in Hive driver
>  - Enabled scroll cursors with support for positioning cursor to start of resultset
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da 
>   jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573 
>   jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java 812ee56 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java fce19bf 
>   ql/src/java/org/apache/hadoop/hive/ql/Context.java ed502a7 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 86db406 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 343f760 
>   ql/src/java/org/apache/hadoop/hive/ql/processors/DfsProcessor.java ce54e0c 
>   service/src/java/org/apache/hive/service/cli/operation/GetCatalogsOperation.java 581e69c

>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java af87a90

>   service/src/java/org/apache/hive/service/cli/operation/GetFunctionsOperation.java 0fe01c0

>   service/src/java/org/apache/hive/service/cli/operation/GetSchemasOperation.java bafe40c

>   service/src/java/org/apache/hive/service/cli/operation/GetTableTypesOperation.java
2be018e 
>   service/src/java/org/apache/hive/service/cli/operation/GetTablesOperation.java 7e8a06b

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2daa9cd

>   service/src/java/org/apache/hive/service/cli/operation/HiveCommandOperation.java a1ac55b

>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 301187d 
> 
> Diff: https://reviews.apache.org/r/16063/diff/
> 
> 
> Testing
> -------
> 
> Added new testcases to TestJdbcDriver2
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message