hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere" <jd...@hortonworks.com>
Subject Re: Review Request 16008: HIVE-5872: Make UDAFs such as GenericUDAFSum report accurate precision/scale for decimal types
Date Wed, 04 Dec 2013 21:46:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16008/#review29754
-----------------------------------------------------------



ql/src/test/results/clientpositive/decimal_udf.q.out
<https://reviews.apache.org/r/16008/#comment57222>

    How do the code changes in sum/average contribute to this change in the test results for
floor()? Was the diff generated on a branch that had other changes on it?


Changes look good.

- Jason Dere


On Dec. 4, 2013, 7:31 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16008/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2013, 7:31 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5872
>     https://issues.apache.org/jira/browse/HIVE-5872
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Main changes: avg() function will return a decimal type with 4 more decimal digits than
the input (in line with MySQL).
>               sum() function will return a decimal type with 10 more integer digits than
the input (can accommodate at least 10b rows).
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFAverage.java fc9eedb 
>   ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFSum.java 69d9087 
>   ql/src/test/queries/clientpositive/decimal_precision.q 1b15282 
>   ql/src/test/queries/clientpositive/decimal_udf.q caa7428 
>   ql/src/test/results/clientpositive/decimal_precision.q.out 530314f 
>   ql/src/test/results/clientpositive/decimal_udf.q.out 95d4e22 
>   serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java 18032d3

> 
> Diff: https://reviews.apache.org/r/16008/diff/
> 
> 
> Testing
> -------
> 
> More tests are added. Existing test output are modified accordingly.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message