hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Hanson" <eh...@microsoft.com>
Subject Re: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution
Date Tue, 03 Dec 2013 22:03:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15869/#review29685
-----------------------------------------------------------



ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java
<https://reviews.apache.org/r/15869/#comment57122>

    need to assert out.noNulls is false after evaluate. Otherwise, isNull array contents are
undefined.


- Eric Hanson


On Dec. 3, 2013, 9:44 p.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15869/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 9:44 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> HIVE-5895 vectorization handles division by zero differently from normal execution
> 
> 
> Diffs
> -----
> 
>   ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6 
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION 
>   ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION 
>   ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java
482df3c 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java
7d517ca 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java
e1ecefa 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2

>   ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 1b79401 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorArithmeticExpressions.java
9de8461 
>   ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorScalarColArithmetic.java
fa4da40 
>   ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION 
>   ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/vectorization_short_regress.q.out 18ff938 
> 
> Diff: https://reviews.apache.org/r/15869/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message