Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7D65310F0D for ; Thu, 28 Nov 2013 00:37:36 +0000 (UTC) Received: (qmail 94252 invoked by uid 500); 28 Nov 2013 00:37:36 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 94141 invoked by uid 500); 28 Nov 2013 00:37:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 94132 invoked by uid 500); 28 Nov 2013 00:37:35 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 94129 invoked by uid 99); 28 Nov 2013 00:37:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Nov 2013 00:37:35 +0000 Date: Thu, 28 Nov 2013 00:37:35 +0000 (UTC) From: "Hive QA (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-5906) TestGenericUDFPower should use delta to compare doubles MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-5906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13834400#comment-13834400 ] Hive QA commented on HIVE-5906: ------------------------------- {color:green}Overall{color}: +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12616149/HIVE-5906.patch {color:green}SUCCESS:{color} +1 4740 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/471/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/471/console Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12616149 > TestGenericUDFPower should use delta to compare doubles > ------------------------------------------------------- > > Key: HIVE-5906 > URL: https://issues.apache.org/jira/browse/HIVE-5906 > Project: Hive > Issue Type: Bug > Components: Tests > Affects Versions: 0.13.0 > Reporter: Szehon Ho > Assignee: Szehon Ho > Fix For: 0.13.0 > > Attachments: HIVE-5906.patch > > > TestGenericUDFPower.testDoulePowerDecimal() uses junit's Assert.assertEquals(double, double) to test double equality on result of power udf function. > Due to floating-number convention, this does not always work. This API is deprecated in favor of Assert.assertEquals(message, double, double, delta). -- This message was sent by Atlassian JIRA (v6.1#6144)