Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 27E311048F for ; Mon, 18 Nov 2013 16:13:28 +0000 (UTC) Received: (qmail 44277 invoked by uid 500); 18 Nov 2013 16:13:25 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 44082 invoked by uid 500); 18 Nov 2013 16:13:24 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 43771 invoked by uid 500); 18 Nov 2013 16:13:23 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 43744 invoked by uid 99); 18 Nov 2013 16:13:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Nov 2013 16:13:22 +0000 Date: Mon, 18 Nov 2013 16:13:22 +0000 (UTC) From: "Brock Noland (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-5565) Limit Hive decimal type maximum precision and scale to 38 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-5565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825431#comment-13825431 ] Brock Noland commented on HIVE-5565: ------------------------------------ Looks like this patch needs some rebasing as DEFAULT_PRECISION is still used here: https://github.com/apache/hive/blob/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java#L423 > Limit Hive decimal type maximum precision and scale to 38 > --------------------------------------------------------- > > Key: HIVE-5565 > URL: https://issues.apache.org/jira/browse/HIVE-5565 > Project: Hive > Issue Type: Task > Components: Types > Affects Versions: 0.13.0 > Reporter: Xuefu Zhang > Assignee: Xuefu Zhang > Attachments: HIVE-5565.1.patch, HIVE-5565.2.patch, HIVE-5565.patch > > > With HIVE-3976, the maximum precision is set to 65, and maximum scale is to 30. After discussing with several folks in the community, it's determined that 38 as a maximum for both precision and scale are probably sufficient, in addition to the potential performance boost that might become possible to some implementation. > This task is to make such a change. The change is expected to be trivial, but it may impact many test cases. The reason for a separate JIRA is that patch in HIVE-3976 is already in a good shape. Rather than destabilizing a bigger patch, a dedicate patch will facilitates both reviews. > The wiki document will be updated shortly. -- This message was sent by Atlassian JIRA (v6.1#6144)