Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C8401044F for ; Wed, 27 Nov 2013 02:21:07 +0000 (UTC) Received: (qmail 36712 invoked by uid 500); 27 Nov 2013 02:21:07 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 36669 invoked by uid 500); 27 Nov 2013 02:21:06 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 36660 invoked by uid 99); 27 Nov 2013 02:21:06 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Nov 2013 02:21:06 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 599841D3C53; Wed, 27 Nov 2013 02:21:02 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1777370950624891780==" MIME-Version: 1.0 Subject: Review Request 15869: HIVE-5895 vectorization handles division by zero differently from normal execution From: "Sergey Shelukhin" To: "hive" , "Sergey Shelukhin" Date: Wed, 27 Nov 2013 02:21:02 -0000 Message-ID: <20131127022102.5111.68886@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sergey Shelukhin" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15869/ X-Sender: "Sergey Shelukhin" Reply-To: "Sergey Shelukhin" X-ReviewRequest-Repository: hive-git --===============1777370950624891780== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15869/ ----------------------------------------------------------- Review request for hive. Repository: hive-git Description ------- HIVE-5895 vectorization handles division by zero differently from normal execution Diffs ----- ant/src/org/apache/hadoop/hive/ant/GenVectorCode.java 5dc50d6 ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideColumn.txt PRE-CREATION ql/src/gen/vectorization/ExpressionTemplates/ColumnDivideScalar.txt PRE-CREATION ql/src/gen/vectorization/ExpressionTemplates/ScalarDivideColumn.txt PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 482df3c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 7d517ca ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java e1ecefa ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NullUtil.java e1867a2 ql/src/test/queries/clientpositive/vectorization_div0.q PRE-CREATION ql/src/test/results/clientpositive/vectorization_div0.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_short_regress.q.out c9296e1 Diff: https://reviews.apache.org/r/15869/diff/ Testing ------- Thanks, Sergey Shelukhin --===============1777370950624891780==--