Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 38B8510B9E for ; Tue, 26 Nov 2013 22:10:26 +0000 (UTC) Received: (qmail 64021 invoked by uid 500); 26 Nov 2013 22:10:25 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 63969 invoked by uid 500); 26 Nov 2013 22:10:25 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 63960 invoked by uid 99); 26 Nov 2013 22:10:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Nov 2013 22:10:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 497251D3C4D; Tue, 26 Nov 2013 22:10:20 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4819788638183026196==" MIME-Version: 1.0 Subject: Review Request 15864: HIVE-4485 - beeline prints null as empty strings From: "Thejas Nair" To: "Thejas Nair" , "hive" Date: Tue, 26 Nov 2013 22:10:20 -0000 Message-ID: <20131126221020.7321.72098@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15864/ X-Sender: "Thejas Nair" Reply-To: "Thejas Nair" X-ReviewRequest-Repository: hive-git --===============4819788638183026196== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15864/ ----------------------------------------------------------- Review request for hive. Bugs: HIVE-4485 https://issues.apache.org/jira/browse/HIVE-4485 Repository: hive-git Description ------- beeline is printing nulls as emtpy strings. There was no way to distinguish between an empty string an a null value. This is inconsistent with hive cli and other databases, they print null as "NULL" string. Diffs ----- beeline/src/java/org/apache/hive/beeline/BeeLine.java bc2f4d8 beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 0884b16 beeline/src/java/org/apache/hive/beeline/BufferedRows.java fc8e62b beeline/src/java/org/apache/hive/beeline/Rows.java a66e709 beeline/src/main/resources/BeeLine.properties 9947007 beeline/src/test/org/apache/hive/beeline/src/test/TestBeeLineWithArgs.java e3c6a72 Diff: https://reviews.apache.org/r/15864/diff/ Testing ------- unit tests included. Also tested manually. Thanks, Thejas Nair --===============4819788638183026196==--