Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 294A210173 for ; Mon, 25 Nov 2013 02:27:17 +0000 (UTC) Received: (qmail 47416 invoked by uid 500); 25 Nov 2013 02:27:16 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 47337 invoked by uid 500); 25 Nov 2013 02:27:16 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 47323 invoked by uid 99); 25 Nov 2013 02:27:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Nov 2013 02:27:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 708791C0288; Mon, 25 Nov 2013 02:27:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7549328360819377386==" MIME-Version: 1.0 Subject: Re: Review Request 15820: HIVE-5839: BytesRefArrayWritable compareTo violates contract From: "Navis Ryu" To: "Navis Ryu" , "Xuefu Zhang" , "hive" Date: Mon, 25 Nov 2013 02:27:11 -0000 Message-ID: <20131125022711.32080.18185@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Navis Ryu" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15820/ X-Sender: "Navis Ryu" References: <20131123044208.28841.7156@reviews.apache.org> In-Reply-To: <20131123044208.28841.7156@reviews.apache.org> Reply-To: "Navis Ryu" X-ReviewRequest-Repository: hive-git --===============7549328360819377386== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15820/#review29357 ----------------------------------------------------------- ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java Took some time to get why this is changed. Could you add some comments on this? - Navis Ryu On Nov. 23, 2013, 4:42 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15820/ > ----------------------------------------------------------- > > (Updated Nov. 23, 2013, 4:42 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5839 > https://issues.apache.org/jira/browse/HIVE-5839 > > > Repository: hive-git > > > Description > ------- > > Modified according to the contract. > > > Diffs > ----- > > ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java d2b06ec > serde/src/java/org/apache/hadoop/hive/serde2/columnar/BytesRefArrayWritable.java 712064e > serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestBytesRefArrayWritable.java PRE-CREATION > > Diff: https://reviews.apache.org/r/15820/diff/ > > > Testing > ------- > > Added new test case. Fixed a old test case. > > > Thanks, > > Xuefu Zhang > > --===============7549328360819377386==--