Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3D44D10C35 for ; Tue, 19 Nov 2013 14:23:37 +0000 (UTC) Received: (qmail 80333 invoked by uid 500); 19 Nov 2013 14:23:35 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 80273 invoked by uid 500); 19 Nov 2013 14:23:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 80263 invoked by uid 99); 19 Nov 2013 14:23:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2013 14:23:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 305F81D3748; Tue, 19 Nov 2013 14:23:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0275184475701011749==" MIME-Version: 1.0 Subject: Re: Review Request 15649: HIVE-5842 - Fix issues with new paths to jar in hcatalog From: "Brock Noland" To: "Mohammad Islam" , "hive" , "Brock Noland" Date: Tue, 19 Nov 2013 14:23:30 -0000 Message-ID: <20131119142330.5849.79837@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15649/ X-Sender: "Brock Noland" References: <20131119003606.5849.3535@reviews.apache.org> In-Reply-To: <20131119003606.5849.3535@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============0275184475701011749== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On Nov. 19, 2013, 12:36 a.m., Mohammad Islam wrote: > > +1 (with minor comments) Thank you for the review! I noted many cleanup opportunities as well... I have created HIVE-5852 to track that issue. - Brock ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15649/#review29087 ----------------------------------------------------------- On Nov. 18, 2013, 4:49 p.m., Brock Noland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15649/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 4:49 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5842 > https://issues.apache.org/jira/browse/HIVE-5842 > > > Repository: hive-git > > > Description > ------- > > Fixes path issues with hcatalog in maven tarball post mavenization. > > Also removes a comical amount of trailing whitespace in hcat scripts. > > > Diffs > ----- > > hcatalog/bin/hcat b4d4226 > hcatalog/bin/hcat.py 53fc387 > hcatalog/bin/hcat_server.py 51a11e6 > hcatalog/bin/hcat_server.sh bf3c3f1 > hcatalog/bin/hcatcfg.py 47a56d8 > hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578 > hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d > > Diff: https://reviews.apache.org/r/15649/diff/ > > > Testing > ------- > > Tested hcat scripts manually > > > Thanks, > > Brock Noland > > --===============0275184475701011749==--