Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C65C110C4A for ; Tue, 19 Nov 2013 03:28:32 +0000 (UTC) Received: (qmail 39070 invoked by uid 500); 19 Nov 2013 03:28:29 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 39027 invoked by uid 500); 19 Nov 2013 03:28:28 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 39017 invoked by uid 99); 19 Nov 2013 03:28:27 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Nov 2013 03:28:27 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6F4E21D3B8C; Tue, 19 Nov 2013 03:28:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2878869638608124453==" MIME-Version: 1.0 Subject: Review Request 15666: HIVE-5847 DatabaseMetadata.getColumns() doesn't show correct column size for char/varchar/decimal From: "Jason Dere" To: "Thejas Nair" Cc: "Jason Dere" , "hive" Date: Tue, 19 Nov 2013 03:28:23 -0000 Message-ID: <20131119032823.5850.64673@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15666/ X-Sender: "Jason Dere" Reply-To: "Jason Dere" X-ReviewRequest-Repository: hive-git --===============2878869638608124453== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15666/ ----------------------------------------------------------- Review request for hive and Thejas Nair. Bugs: HIVE-5847 https://issues.apache.org/jira/browse/HIVE-5847 Repository: hive-git Description ------- - getColumns(): column_size, decimal_digits, num_prec_radix should use the proper type info for char/varchar/decimal - getColumns(): column_size set to 29 for timestamp, to match JDBC ResultSetMetadata - getColumns() and ResultSetMetadata should return same scale for timestamp (9). - Changed radix to 10 for all numeric types; was previously set to 2 for float/double Diffs ----- itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 42ec32a service/src/java/org/apache/hive/service/cli/Type.java 9329392 service/src/java/org/apache/hive/service/cli/TypeDescriptor.java fb0236c service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java af87a90 service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2daa9cd Diff: https://reviews.apache.org/r/15666/diff/ Testing ------- Thanks, Jason Dere --===============2878869638608124453==--