Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ADF8010F68 for ; Sat, 16 Nov 2013 02:34:45 +0000 (UTC) Received: (qmail 73684 invoked by uid 500); 16 Nov 2013 02:34:45 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 73629 invoked by uid 500); 16 Nov 2013 02:34:45 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 73614 invoked by uid 99); 16 Nov 2013 02:34:45 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Nov 2013 02:34:45 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 763201D3B43; Sat, 16 Nov 2013 02:34:41 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4487660782952244274==" MIME-Version: 1.0 Subject: Re: Review Request 15525: HIVE-3107: Improve semantic analyzer to better handle column name references in group by/sort by clauses From: "Harish Butani" To: "Xuefu Zhang" , "Ashutosh Chauhan" Cc: "Harish Butani" , "hive" Date: Sat, 16 Nov 2013 02:34:41 -0000 Message-ID: <20131116023441.3038.79055@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Harish Butani" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15525/ X-Sender: "Harish Butani" References: <20131114191753.8996.8379@reviews.apache.org> In-Reply-To: <20131114191753.8996.8379@reviews.apache.org> Reply-To: "Harish Butani" X-ReviewRequest-Repository: hive-git --===============4487660782952244274== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15525/ ----------------------------------------------------------- (Updated Nov. 16, 2013, 2:34 a.m.) Review request for hive, Ashutosh Chauhan and Xuefu Zhang. Changes ------- - changed altInvRslvMap to contain one entry - carry forward alt mapping for Select - added test case from HIVE-1922 Bugs: hive-3107 https://issues.apache.org/jira/browse/hive-3107 Repository: hive-git Description ------- Following queries all fail with various SemanticExceptions: explain select t.c from t group by c; explain select t.c from t group by c sort by t.c; explain select t.c as c0 from t group by c0; explain select t.c from t group by t.c sort by t.c; Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java 7a7f3ef ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 908546e ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java d797407 ql/src/test/queries/clientnegative/notable_alias3.q 6cc3e87 ql/src/test/queries/clientpositive/groupby_resolution.q PRE-CREATION ql/src/test/queries/clientpositive/notable_alias3.q PRE-CREATION ql/src/test/results/clientnegative/notable_alias3.q.out cadca6e ql/src/test/results/clientpositive/groupby_resolution.q.out PRE-CREATION ql/src/test/results/clientpositive/notable_alias3.q.out PRE-CREATION ql/src/test/results/compiler/errors/nonkey_groupby.q.out a13d45d ql/src/test/results/compiler/plan/groupby1.q.xml 485c323 ql/src/test/results/compiler/plan/groupby5.q.xml abdbff0 Diff: https://reviews.apache.org/r/15525/diff/ Testing ------- added groupby_resolution.q that tests the jira listed. Also added tests for having and windowing. Thanks, Harish Butani --===============4487660782952244274==--