Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C0DB101B8 for ; Fri, 15 Nov 2013 18:18:31 +0000 (UTC) Received: (qmail 12974 invoked by uid 500); 15 Nov 2013 18:18:30 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 12897 invoked by uid 500); 15 Nov 2013 18:18:29 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 12886 invoked by uid 99); 15 Nov 2013 18:18:28 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Nov 2013 18:18:28 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8988E1D3B1A; Fri, 15 Nov 2013 18:18:24 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7180762679859711417==" MIME-Version: 1.0 Subject: Re: Review Request 15308: HIVE-5564: Need to accomodate table decimal columns that were defined prior to HIVE-3976 From: "Brock Noland" To: "Xuefu Zhang" , "hive" , "Brock Noland" Date: Fri, 15 Nov 2013 18:18:24 -0000 Message-ID: <20131115181824.26301.54835@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Brock Noland" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/15308/ X-Sender: "Brock Noland" References: <20131113034102.22932.30977@reviews.apache.org> In-Reply-To: <20131113034102.22932.30977@reviews.apache.org> Reply-To: "Brock Noland" X-ReviewRequest-Repository: hive-git --===============7180762679859711417== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15308/#review28980 ----------------------------------------------------------- Ship it! Ship It! - Brock Noland On Nov. 13, 2013, 3:41 a.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15308/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2013, 3:41 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5564 > https://issues.apache.org/jira/browse/HIVE-5564 > > > Repository: hive-git > > > Description > ------- > > Patch addresses the missing precision/scale in the old metadata. It also put costmatics on displayed column type for decimal on the console. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c > ql/src/test/queries/clientpositive/decimal_1.q f8b3661 > ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 2982cf6 > > Diff: https://reviews.apache.org/r/15308/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Xuefu Zhang > > --===============7180762679859711417==--