Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============5874755517162326508=="
MIME-Version: 1.0
Subject: Re: Review Request 15151: Better error reporting by async threads in
 HiveServer2
From: "Vaibhav Gumashta" <vgumashta@hortonworks.com>
To: "Prasad Mujumdar" <prasadm@cloudera.com>,
 "Thejas Nair" <thejas@hortonworks.com>
Cc: "Vaibhav Gumashta" <vgumashta@hortonworks.com>,
 "hive" <dev@hive.apache.org>
Date: Tue, 12 Nov 2013 23:05:34 -0000
Message-ID: <20131112230534.7728.21438@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vaibhav Gumashta" <noreply@reviews.apache.org>
References: <20131111195401.11927.48259@reviews.apache.org>
In-Reply-To: <20131111195401.11927.48259@reviews.apache.org>
Reply-To: "Vaibhav Gumashta" <vgumashta@hortonworks.com>

--===============5874755517162326508==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


> On Nov. 11, 2013, 7:54 p.m., Thejas Nair wrote:
> > service/if/TCLIService.thrift, line 917
> > <https://reviews.apache.org/r/15151/diff/4/?file=382149#file382149line917>
> >
> >     This will not be backward compatible. It would be better to add a new optional field in the response, that has the additional error information.
> >

Fixed. Thanks for pointing out!


- Vaibhav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15151/#review28683
-----------------------------------------------------------


On Nov. 11, 2013, 7:23 p.m., Vaibhav Gumashta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15151/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2013, 7:23 p.m.)
> 
> 
> Review request for hive, Prasad Mujumdar and Thejas Nair.
> 
> 
> Bugs: HIVE-5230
>     https://issues.apache.org/jira/browse/HIVE-5230
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> [HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object). 
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/service/cli/CLIServiceTest.java PRE-CREATION 
>   itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java PRE-CREATION 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java fce19bf 
>   service/if/TCLIService.thrift 1f49445 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 8c85386 
>   service/src/java/org/apache/hive/service/cli/CLIServiceClient.java 14ef54f 
>   service/src/java/org/apache/hive/service/cli/EmbeddedCLIServiceClient.java 9dca874 
>   service/src/java/org/apache/hive/service/cli/HiveSQLException.java 74e8b94 
>   service/src/java/org/apache/hive/service/cli/ICLIService.java f647ce6 
>   service/src/java/org/apache/hive/service/cli/OperationState.java 1ec6bd1 
>   service/src/java/org/apache/hive/service/cli/OperationStatus.java PRE-CREATION 
>   service/src/java/org/apache/hive/service/cli/operation/Operation.java 6f4b8dc 
>   service/src/java/org/apache/hive/service/cli/operation/OperationManager.java bcdb67f 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 9df110e 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIServiceClient.java 9bb2a0f 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a 
>   service/src/test/org/apache/hive/service/cli/thrift/ThriftCLIServiceTest.java ff7166d 
> 
> Diff: https://reviews.apache.org/r/15151/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vaibhav Gumashta
> 
>


--===============5874755517162326508==--