hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remus Rusanu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5845) CTAS failed on vectorized code path
Date Wed, 20 Nov 2013 14:35:41 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827703#comment-13827703
] 

Remus Rusanu commented on HIVE-5845:
------------------------------------

The uploaded fix addresses all the issues I found:

 - changes the OrcStruct serialization to use the correct object inspector (the one that writes
into the OrcStruct fields)
 - the VectorExpressionWriterFactory was refactored to handle all assignments/writes and new
object creation via the object inspectors, rather than assumming Writable types
 - a new API is available on the VectorExpressionWritter: setValue, which writes the value
into the passed in object rather that returning a mutated the per-writer singleton. This was
necessary for the OrcStruct vector serialization, which would end up reusing the same instance
on all rows in the vector otherwise
 - changed the VectorExpressionWriter to use TypeInfo Category and PrimitiveCategory rather
than type name string comparison
 - Have the VectorExpressionWriter generate writers from ObjectInspector and derive the OI
from ExprNodeDesc rather than the other way around
 - extended the TestVectorExpressionWriter unit tests to cover the setValue API and struct
fields assignment

> CTAS failed on vectorized code path
> -----------------------------------
>
>                 Key: HIVE-5845
>                 URL: https://issues.apache.org/jira/browse/HIVE-5845
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Ashutosh Chauhan
>            Assignee: Remus Rusanu
>         Attachments: HIVE-5845.1.patch
>
>
> Following query fails:
>  create table store_sales_2 stored as orc as select * from alltypesorc;



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message