hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <>
Subject [jira] [Commented] (HIVE-5817) column name to index mapping in VectorizationContext is broken
Date Tue, 26 Nov 2013 19:34:35 GMT


Sergey Shelukhin commented on HIVE-5817:

Patch looks good to me for what it does, +1
Should it also handle GBY?
Do you want to file a separate JIRA for the select case? I can try to make repro next week

> column name to index mapping in VectorizationContext is broken
> --------------------------------------------------------------
>                 Key: HIVE-5817
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>    Affects Versions: 0.13.0
>            Reporter: Sergey Shelukhin
>            Assignee: Remus Rusanu
>            Priority: Critical
>         Attachments: HIVE-5817-uniquecols.broken.patch, HIVE-5817.00-broken.patch, HIVE-5817.4.patch,
HIVE-5817.5.patch, HIVE-5817.6.patch
> Columns coming from different operators may have the same internal names ("_colNN").
There exists a query in the form {{select b.cb, from a JOIN b ON ... JOIN x ON ...;}}
 (distilled from a more complex query), which runs ok w/o vectorization. With vectorization,
it will run ok for most ca, but for some ca it will fail (or can probably return incorrect
results). That is because when building column-to-VRG-index map in VectorizationContext, internal
column name for ca that the first map join operator adds to the mapping may be the same as
internal name for cb that the 2nd one tries to add. 2nd VMJ doesn't add it (see code in ctor),
and when it's time for it to output stuff, it retrieves wrong index from the map by name,
and then wrong vector from VRG.

This message was sent by Atlassian JIRA

View raw message