hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5763) ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises
Date Thu, 07 Nov 2013 13:43:19 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815964#comment-13815964
] 

Hive QA commented on HIVE-5763:
-------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12612443/HIVE-5763.patch

{color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 4577 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join13
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_join2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_6
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin_negative3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_map_ppr
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_skewjoin
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin_13
{noformat}

Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/163/testReport
Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/163/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests failed with: TestsFailedException: 7 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12612443

> ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises
> ----------------------------------------------------------------------
>
>                 Key: HIVE-5763
>                 URL: https://issues.apache.org/jira/browse/HIVE-5763
>             Project: Hive
>          Issue Type: Bug
>          Components: Query Processor
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>            Priority: Minor
>         Attachments: HIVE-5763.patch
>
>
> This makes the generated expression tree unreadable.
> {code}
>   public String toString() {
>     StringBuilder sb = new StringBuilder();
>     sb.append(genericUDF.getClass().toString());
>     sb.append("(");
>     for (int i = 0; i < chidren.size(); i++) {
>       if (i > 0) {
>         sb.append(", ");
>       }
>       sb.append(chidren.get(i).toString());
>     }
>     sb.append("("); -- This needs to be removed.
>     sb.append(")");
>     return sb.toString();
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message