hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-5732) HiveServer2: Duplicated new OperationManager in SessionManager
Date Tue, 12 Nov 2013 14:54:21 GMT

     [ https://issues.apache.org/jira/browse/HIVE-5732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Brock Noland updated HIVE-5732:
-------------------------------

    Description: 
{noformat}
public class SessionManager extends CompositeService {
  private static final Log LOG = LogFactory.getLog(CompositeService.class);
  private HiveConf hiveConf;
  private final Map<SessionHandle, HiveSession> handleToSession = new HashMap<SessionHandle,
HiveSession>();
  private OperationManager operationManager = new OperationManager();
  private static final Object sessionMapLock = new Object();
  private ExecutorService backgroundOperationPool;

  public SessionManager() {
    super("SessionManager");
  }

  @Override
  public synchronized void init(HiveConf hiveConf) {
    this.hiveConf = hiveConf;
    operationManager = new OperationManager();
    int backgroundPoolSize = hiveConf.getIntVar(ConfVars.HIVE_SERVER2_ASYNC_EXEC_THREADS);
    LOG.info("HiveServer2: Async execution pool size" + backgroundPoolSize);
    backgroundOperationPool = Executors.newFixedThreadPool(backgroundPoolSize);
    addService(operationManager);
    super.init(hiveConf);
  }
{noformat}

  was:
public class SessionManager extends CompositeService {
  private static final Log LOG = LogFactory.getLog(CompositeService.class);
  private HiveConf hiveConf;
  private final Map<SessionHandle, HiveSession> handleToSession = new HashMap<SessionHandle,
HiveSession>();
  private OperationManager operationManager = new OperationManager();
  private static final Object sessionMapLock = new Object();
  private ExecutorService backgroundOperationPool;

  public SessionManager() {
    super("SessionManager");
  }

  @Override
  public synchronized void init(HiveConf hiveConf) {
    this.hiveConf = hiveConf;
    operationManager = new OperationManager();
    int backgroundPoolSize = hiveConf.getIntVar(ConfVars.HIVE_SERVER2_ASYNC_EXEC_THREADS);
    LOG.info("HiveServer2: Async execution pool size" + backgroundPoolSize);
    backgroundOperationPool = Executors.newFixedThreadPool(backgroundPoolSize);
    addService(operationManager);
    super.init(hiveConf);
  }


> HiveServer2: Duplicated new OperationManager in SessionManager
> --------------------------------------------------------------
>
>                 Key: HIVE-5732
>                 URL: https://issues.apache.org/jira/browse/HIVE-5732
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.12.0
>            Reporter: Schubert Zhang
>            Assignee: Navis
>            Priority: Trivial
>         Attachments: HIVE-5732.1.patch.txt
>
>
> {noformat}
> public class SessionManager extends CompositeService {
>   private static final Log LOG = LogFactory.getLog(CompositeService.class);
>   private HiveConf hiveConf;
>   private final Map<SessionHandle, HiveSession> handleToSession = new HashMap<SessionHandle,
HiveSession>();
>   private OperationManager operationManager = new OperationManager();
>   private static final Object sessionMapLock = new Object();
>   private ExecutorService backgroundOperationPool;
>   public SessionManager() {
>     super("SessionManager");
>   }
>   @Override
>   public synchronized void init(HiveConf hiveConf) {
>     this.hiveConf = hiveConf;
>     operationManager = new OperationManager();
>     int backgroundPoolSize = hiveConf.getIntVar(ConfVars.HIVE_SERVER2_ASYNC_EXEC_THREADS);
>     LOG.info("HiveServer2: Async execution pool size" + backgroundPoolSize);
>     backgroundOperationPool = Executors.newFixedThreadPool(backgroundPoolSize);
>     addService(operationManager);
>     super.init(hiveConf);
>   }
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message