hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland (JIRA)" <>
Subject [jira] [Commented] (HIVE-5704) A couple of generic UDFs are not in the right folder/package
Date Wed, 06 Nov 2013 16:49:24 GMT


Brock Noland commented on HIVE-5704:

bq. Please note that patch contains updates to file, which is required
for this JIRA. Thus, that change needs to be committed.

Then just include a separate patch. For example when file moves are required, you have three

* HIVE-XXXX.N.patch - the patch for testing which includes the moves and the other changes
* HIVE-XXX.N-for-commit.patch
* list of commands todo the file moves.

I know that is a patch but losing the history of files is not something we should do when
it's avoidable. To me it looks like the only thing needed in the for-commit patch is:

diff --git ql/src/java/org/apache/hadoop/hive/ql/exec/ ql/src/java/org/apache/hadoop/hive/ql/exec/
index 898b6a5..fbde66d 100644
--- ql/src/java/org/apache/hadoop/hive/ql/exec/
+++ ql/src/java/org/apache/hadoop/hive/ql/exec/
@@ -44,8 +44,6 @@
 import org.apache.hadoop.hive.ql.parse.SemanticException;
 import org.apache.hadoop.hive.ql.plan.ExprNodeDesc;
 import org.apache.hadoop.hive.ql.plan.ExprNodeGenericFuncDesc;
-import org.apache.hadoop.hive.ql.udf.GenericUDFDecode;
-import org.apache.hadoop.hive.ql.udf.GenericUDFEncode;
 import org.apache.hadoop.hive.ql.udf.SettableUDF;
 import org.apache.hadoop.hive.ql.udf.UDAFPercentile;
 import org.apache.hadoop.hive.ql.udf.UDFAcos;

> A couple of generic UDFs are not in the right folder/package
> ------------------------------------------------------------
>                 Key: HIVE-5704
>                 URL:
>             Project: Hive
>          Issue Type: Task
>          Components: UDF
>    Affects Versions: 0.12.0
>            Reporter: Xuefu Zhang
>            Assignee: Xuefu Zhang
>            Priority: Trivial
>         Attachments: HIVE-5704.1.patch, HIVE-5704.patch
> There are two generic UDFs are in the package for non-generic UDFs. I think it's better
to be consistent but putting them in the udf.generic package

This message was sent by Atlassian JIRA

View raw message