hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Navis Ryu" <navis....@nexr.com>
Subject Re: Review Request 15820: HIVE-5839: BytesRefArrayWritable compareTo violates contract
Date Mon, 25 Nov 2013 02:27:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15820/#review29357
-----------------------------------------------------------



ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
<https://reviews.apache.org/r/15820/#comment56556>

    Took some time to get why this is changed. Could you add some comments on this?


- Navis Ryu


On Nov. 23, 2013, 4:42 a.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15820/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 4:42 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5839
>     https://issues.apache.org/jira/browse/HIVE-5839
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Modified according to the contract.
> 
> 
> Diffs
> -----
> 
>   ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java d2b06ec 
>   serde/src/java/org/apache/hadoop/hive/serde2/columnar/BytesRefArrayWritable.java 712064e

>   serde/src/test/org/apache/hadoop/hive/serde2/columnar/TestBytesRefArrayWritable.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/15820/diff/
> 
> 
> Testing
> -------
> 
>  Added new test case. Fixed a old test case.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message