hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho" <sze...@cloudera.com>
Subject Re: Review Request 15816: HIVE-3181 getDatabaseMajor/Minor version does not return values
Date Sat, 23 Nov 2013 01:40:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15816/
-----------------------------------------------------------

(Updated Nov. 23, 2013, 1:40 a.m.)


Review request for hive.


Changes
-------

Made a small optimization to lazily cache the db version number.  This will decrease RPC calls
to server, if more than one getXXVersion() method is called.


Bugs: HIVE-3181
    https://issues.apache.org/jira/browse/HIVE-3181


Repository: hive-git


Description
-------

This will parse the database version to determine the major and minor versions.


Diffs (updated)
-----

  itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da 
  jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java ef39573 
  jdbc/src/java/org/apache/hive/jdbc/HiveDatabaseMetaData.java c447d44 
  jdbc/src/java/org/apache/hive/jdbc/Utils.java 4d75d98 

Diff: https://reviews.apache.org/r/15816/diff/


Testing
-------


Thanks,

Szehon Ho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message