hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 15666: HIVE-5847 DatabaseMetadata.getColumns() doesn't show correct column size for char/varchar/decimal
Date Tue, 19 Nov 2013 17:56:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15666/#review29117
-----------------------------------------------------------


Patch looks good. A few questions below.


service/src/java/org/apache/hive/service/cli/TypeDescriptor.java
<https://reviews.apache.org/r/15666/#comment56242>

    Original is 30. What's the reason for changing it to 29?



service/src/java/org/apache/hive/service/cli/TypeDescriptor.java
<https://reviews.apache.org/r/15666/#comment56243>

    this seems to be new. How is this number determined? I'm not sure if the time part of
timestamp is the same as in a double such as 3.14.



service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java
<https://reviews.apache.org/r/15666/#comment56245>

    do we need to consider for numeric types the sign and decimal point itself? In other words,
is this same as display size?


- Xuefu Zhang


On Nov. 19, 2013, 3:28 a.m., Jason Dere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15666/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 3:28 a.m.)
> 
> 
> Review request for hive and Thejas Nair.
> 
> 
> Bugs: HIVE-5847
>     https://issues.apache.org/jira/browse/HIVE-5847
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> - getColumns(): column_size, decimal_digits, num_prec_radix should use the proper type
info for char/varchar/decimal
> - getColumns(): column_size set to 29 for timestamp, to match JDBC ResultSetMetadata
> - getColumns() and ResultSetMetadata should return same scale for timestamp (9).
> - Changed radix to 10 for all numeric types; was previously set to 2 for float/double
> 
> 
> Diffs
> -----
> 
>   itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java 7b1c9da 
>   jdbc/src/java/org/apache/hive/jdbc/JdbcColumn.java 42ec32a 
>   service/src/java/org/apache/hive/service/cli/Type.java 9329392 
>   service/src/java/org/apache/hive/service/cli/TypeDescriptor.java fb0236c 
>   service/src/java/org/apache/hive/service/cli/operation/GetColumnsOperation.java af87a90

>   service/src/java/org/apache/hive/service/cli/operation/GetTypeInfoOperation.java 2daa9cd

> 
> Diff: https://reviews.apache.org/r/15666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason Dere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message