hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 15649: HIVE-5842 - Fix issues with new paths to jar in hcatalog
Date Tue, 19 Nov 2013 14:23:30 GMT


> On Nov. 19, 2013, 12:36 a.m., Mohammad Islam wrote:
> > +1 (with minor comments)

Thank you for the review! I noted many cleanup opportunities as well... I have created HIVE-5852
to track that issue.


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15649/#review29087
-----------------------------------------------------------


On Nov. 18, 2013, 4:49 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15649/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2013, 4:49 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5842
>     https://issues.apache.org/jira/browse/HIVE-5842
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Fixes path issues with hcatalog in maven tarball post mavenization.
> 
> Also removes a comical amount of trailing whitespace in hcat scripts.
> 
> 
> Diffs
> -----
> 
>   hcatalog/bin/hcat b4d4226 
>   hcatalog/bin/hcat.py 53fc387 
>   hcatalog/bin/hcat_server.py 51a11e6 
>   hcatalog/bin/hcat_server.sh bf3c3f1 
>   hcatalog/bin/hcatcfg.py 47a56d8 
>   hcatalog/webhcat/svr/src/main/bin/webhcat_config.sh 6b0b578 
>   hcatalog/webhcat/svr/src/main/bin/webhcat_server.sh 600c16d 
> 
> Diff: https://reviews.apache.org/r/15649/diff/
> 
> 
> Testing
> -------
> 
> Tested hcat scripts manually
> 
> 
> Thanks,
> 
> Brock Noland
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message