hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohammad Islam" <misla...@yahoo.com>
Subject Re: Review Request 15213: HIVE-5731: Use new GenericUDF instead of basic UDF for UDFDate* classes
Date Mon, 11 Nov 2013 21:03:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15213/
-----------------------------------------------------------

(Updated Nov. 11, 2013, 9:03 p.m.)


Review request for hive.


Changes
-------

Update after incorporating with Ashutosh's comments.


Bugs: HIVE-5731
    https://issues.apache.org/jira/browse/HIVE-5731


Repository: hive-git


Description
-------

GenericUDF class is the latest and recommended base class for any UDFs.
This JIRA is to change the current UDFDate* classes extended from GenericUDF.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 8d3a84f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDate.java 3df453c 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateAdd.java b1b0bf2 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateDiff.java da14c4f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDateSub.java c8a1d1f 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDate.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateAdd.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateDiff.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFDateSub.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDate.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateAdd.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateDiff.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestGenericUDFDateSub.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateAdd.java f0af069 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateDiff.java 8a6dbc3 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFDateSub.java fa722a9 
  ql/src/test/results/clientpositive/udf_to_date.q.out 6ff5ee8 

Diff: https://reviews.apache.org/r/15213/diff/


Testing
-------


Thanks,

Mohammad Islam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message