hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harish Butani" <rhbut...@gmail.com>
Subject Review Request 15361: HIVE-5784: Group By Operator doesn't carry forward table aliases in its RowResolver
Date Fri, 08 Nov 2013 19:43:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15361/
-----------------------------------------------------------

Review request for hive and Ashutosh Chauhan.


Bugs: hive-5784
    https://issues.apache.org/jira/browse/hive-5784


Repository: hive-git


Description
-------

The following queries fails:
select b.key, count(*) from src b group by key
select key, count(*) from src b group by b.key
with a SemanticException; the select expression b.key (key in the 2nd query) are not resolved
by the GBy RowResolver.
This is because the GBy RowResolver only supports resolving based on an AST.toStringTree match.
Underlying issue is that a RowResolver doesn't allow multiple mappings to the same ColumnInfo.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java 908546e 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5305537 
  ql/src/test/queries/clientpositive/groupby_resolution.q PRE-CREATION 
  ql/src/test/results/clientpositive/groupby_resolution.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/15361/diff/


Testing
-------

added test groupby_resolution.q


Thanks,

Harish Butani


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message