hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas Nair" <the...@hortonworks.com>
Subject Re: Review Request 14486: HIVE-5441: Async query execution doesn't return resultset status
Date Fri, 08 Nov 2013 00:22:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14486/#review28467
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/14486/#comment55282>

    OK, I see what you mean. I was looking at just the commented line, and didn't look at
the full view-diff page. Yes, the releaseLocks won't get called. That looks like a problem.
    
    Thanks to Vaibhav to pointing it out to me.


- Thejas Nair


On Nov. 6, 2013, 11:50 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14486/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2013, 11:50 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5441
>     https://issues.apache.org/jira/browse/HIVE-5441
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Separate out the query compilation and execute that part synchronously.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java c09ffde 
>   service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 4ee1b74 
>   service/src/test/org/apache/hive/service/cli/CLIServiceTest.java cd9d99a 
> 
> Diff: https://reviews.apache.org/r/14486/diff/
> 
> 
> Testing
> -------
> 
> Added test cases
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message