hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 15294: HIVE-5765 Beeline throws NPE when -e option is used
Date Thu, 07 Nov 2013 00:57:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15294/#review28341
-----------------------------------------------------------



beeline/src/java/org/apache/hive/beeline/Commands.java
<https://reviews.apache.org/r/15294/#comment55167>

    The comment is a little confusing to me. How about something like:
    
    "When using -e, console reader is not initialized and command is a single line"


- Brock Noland


On Nov. 7, 2013, 12:08 a.m., Szehon Ho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15294/
> -----------------------------------------------------------
> 
> (Updated Nov. 7, 2013, 12:08 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> When running Beeline with -e option to pass in sql commands, a null pointer exception
is thrown, even though the command completes successfully.
> 
> Beeline command execution has some pre-execution logic to get the rest multi-line command
using the consoleReader.  However, there is no console-reader available when beeline is initializing
and running the command passed in -e.  Therefore, we would want to skip the multi-line logic,
that is not applicable for commands passed in with -e flag.
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/Commands.java 91ee3b3 
> 
> Diff: https://reviews.apache.org/r/15294/diff/
> 
> 
> Testing
> -------
> 
> Manually tested, and ran TestBeelineWithArgs.
> 
> 
> Thanks,
> 
> Szehon Ho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message