hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 15217: HIVE-5726: The DecimalTypeInfo instance associated with a decimal constant is not in line with the precision/scale of the constant
Date Tue, 05 Nov 2013 19:31:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15217/#review28202
-----------------------------------------------------------


This looks very good!  Why didn't we add a new test to TestHiveDecimal? It looks like this
functionality could be tested there.

- Brock Noland


On Nov. 4, 2013, 11:40 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15217/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2013, 11:40 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5726
>     https://issues.apache.org/jira/browse/HIVE-5726
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> With this patch, the resuting schema from constant is in accordance with the constant
instead of the default from the type.
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/common/type/HiveDecimal.java 606f6d4 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 47d7995 
>   ql/src/test/queries/clientpositive/ctas_hadoop20.q 4961b97 
>   ql/src/test/results/clientpositive/ctas_hadoop20.q.out 885e985 
>   ql/src/test/results/clientpositive/literal_decimal.q.out 2d1ae55 
> 
> Diff: https://reviews.apache.org/r/15217/diff/
> 
> 
> Testing
> -------
> 
> New tests are added. Test suite passed.
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message