hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 15113: HIVE-5356: Move arithmatic UDFs to generic UDF implementations
Date Sun, 03 Nov 2013 19:26:20 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15113/
-----------------------------------------------------------

(Updated Nov. 3, 2013, 7:26 p.m.)


Review request for hive.


Bugs: HIVe-5356
    https://issues.apache.org/jira/browse/HIVe-5356


Repository: hive-git


Description
-------

Replace plus, minus, and so on 6 old UDFs with generic UDF implementations.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 898b6a5 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java dd8d7dd 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 47d7995 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBaseNumericOp.java 1e74fce 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java da01934 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java 0996231 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java 0942ac3 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 07c1957 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java cfe7b2b 
  ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 0da7eae 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseNumeric.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPDivide.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMinus.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMod.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPMultiply.java PRE-CREATION

  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPPlus.java PRE-CREATION 
  ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFPosMod.java PRE-CREATION 
  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 4aeb4e6

  ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 1e49a2e

  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPMod.java 4c2e722 
  ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFPosMod.java 2a301bc 
  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPDivide.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMinus.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMod.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPMultiply.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFOPPlus.java PRE-CREATION

  ql/src/test/org/apache/hadoop/hive/ql/udf/generic/TestGenericUDFPosMod.java PRE-CREATION

  ql/src/test/queries/clientpositive/ctas_hadoop20.q 4961b97 
  ql/src/test/results/clientpositive/ctas_hadoop20.q.out 885e985 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
22e5ec5 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java
c19f5aa 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantByteObjectInspector.java
0915562 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveDecimalObjectInspector.java
a9ca7bd 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantIntObjectInspector.java
942a178 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantLongObjectInspector.java
ad3a063 
  serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantShortObjectInspector.java
6b67dac 
  serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/HiveDecimalUtils.java 420509c 

Diff: https://reviews.apache.org/r/15113/diff/


Testing
-------

Full set of unit tests is to be run. Old testcases are also migrated.


Thanks,

Xuefu Zhang


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message