Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A1F5B1066E for ; Mon, 28 Oct 2013 14:43:49 +0000 (UTC) Received: (qmail 42563 invoked by uid 500); 28 Oct 2013 14:43:44 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 42504 invoked by uid 500); 28 Oct 2013 14:43:40 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 42481 invoked by uid 500); 28 Oct 2013 14:43:35 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 42469 invoked by uid 99); 28 Oct 2013 14:43:31 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Oct 2013 14:43:31 +0000 Date: Mon, 28 Oct 2013 14:43:31 +0000 (UTC) From: "Gopal V (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-5663) Refactor ORC RecordReader to operate on direct & wrapped ByteBuffers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806815#comment-13806815 ] Gopal V commented on HIVE-5663: ------------------------------- Ah, okay. I was just following the original code pattern, which had code like {code} private byte[] compressed = null; {code} which was being replaced with the ByteBuffer. I can amend that, but it made my diffs look "same-ish" when I was viewing it side-by-side with the current patch. > Refactor ORC RecordReader to operate on direct & wrapped ByteBuffers > -------------------------------------------------------------------- > > Key: HIVE-5663 > URL: https://issues.apache.org/jira/browse/HIVE-5663 > Project: Hive > Issue Type: Improvement > Components: File Formats > Affects Versions: 0.13.0 > Environment: Ubuntu LXC > Reporter: Gopal V > Assignee: Gopal V > Labels: ORC > Attachments: HIVE-5663.01.patch > > > The current ORC RecordReader implementation assumes array structures backing the ByteBuffers it passes around between RecordReaderImpl and Compressed/Uncompressed InStream objects. > This patch attempts to refactor those assumptions out of both classes, allowing the future use of direct byte buffers within ORC (as might come from HDFS zero-copy readers). -- This message was sent by Atlassian JIRA (v6.1#6144)