Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C54710CB4 for ; Sat, 26 Oct 2013 05:08:45 +0000 (UTC) Received: (qmail 63133 invoked by uid 500); 26 Oct 2013 05:08:43 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 63082 invoked by uid 500); 26 Oct 2013 05:08:43 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 63072 invoked by uid 99); 26 Oct 2013 05:08:42 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 26 Oct 2013 05:08:42 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D69EF1D377A; Sat, 26 Oct 2013 05:08:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1937236924752139747==" MIME-Version: 1.0 Subject: Review Request 14973: HIVE-5655: Hive incorrecly handles divide-by-zero case From: "Xuefu Zhang" To: "Brock Noland" Cc: "Xuefu Zhang" , "hive" Date: Sat, 26 Oct 2013 05:08:38 -0000 Message-ID: <20131026050838.3694.43752@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Xuefu Zhang" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14973/ X-Sender: "Xuefu Zhang" Reply-To: "Xuefu Zhang" --===============1937236924752139747== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14973/ ----------------------------------------------------------- Review request for hive and Brock Noland. Bugs: HIVE-5655 https://issues.apache.org/jira/browse/HIVE-5655 Repository: hive-git Description ------- Now the behavior for double type is consistent with that for decimal type. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java b98a043 ql/src/test/org/apache/hadoop/hive/ql/udf/TestUDFOPDivide.java PRE-CREATION ql/src/test/results/beelinepositive/udf_round.q.out 9faa1f8 ql/src/test/results/clientpositive/udf_round.q.out 9ad1d91 ql/src/test/results/clientpositive/udf_round_2.q.out 5dbbd2b ql/src/test/results/clientpositive/vectorization_short_regress.q.out 68a05b2 Diff: https://reviews.apache.org/r/14973/diff/ Testing ------- Added new test cases. Updated a few existing tests. Thanks, Xuefu Zhang --===============1937236924752139747==--