Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02B2110F82 for ; Fri, 25 Oct 2013 01:24:57 +0000 (UTC) Received: (qmail 82825 invoked by uid 500); 25 Oct 2013 01:24:56 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 82780 invoked by uid 500); 25 Oct 2013 01:24:56 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 82769 invoked by uid 99); 25 Oct 2013 01:24:56 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Oct 2013 01:24:56 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 673C21D3730; Fri, 25 Oct 2013 01:24:54 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0128907088306535644==" MIME-Version: 1.0 Subject: Re: Review Request 14484: HIVE-5440: HiveServer2 doesn't apply SQL operation's config property From: "Thejas Nair" To: "Prasad Mujumdar" , "Vaibhav Gumashta" , "Thejas Nair" , "hive" Date: Fri, 25 Oct 2013 01:24:54 -0000 Message-ID: <20131025012454.3694.86890@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Thejas Nair" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14484/ X-Sender: "Thejas Nair" References: <20131004071645.22177.9564@reviews.apache.org> In-Reply-To: <20131004071645.22177.9564@reviews.apache.org> Reply-To: "Thejas Nair" --===============0128907088306535644== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14484/#review27501 ----------------------------------------------------------- Ship it! Ship It! - Thejas Nair On Oct. 4, 2013, 7:16 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14484/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 7:16 a.m.) > > > Review request for hive. > > > Bugs: HIVE-5440 > https://issues.apache.org/jira/browse/HIVE-5440 > > > Repository: hive-git > > > Description > ------- > > The patch clones the session config object and applies the specified per-operation properties, if any. This way the changes are applicable to the current driver and not to the parent session. The patch also extends this for the async query to isolate the session and query config. > > > Diffs > ----- > > service/src/java/org/apache/hive/service/cli/operation/ExecuteStatementOperation.java 6b5a5c3 > service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java bb0f711 > service/src/test/org/apache/hive/service/cli/CLIServiceTest.java 794ede8 > > Diff: https://reviews.apache.org/r/14484/diff/ > > > Testing > ------- > > Added new test cases for the patch > > > Thanks, > > Prasad Mujumdar > > --===============0128907088306535644==--