Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89B3410BE2 for ; Mon, 21 Oct 2013 18:00:06 +0000 (UTC) Received: (qmail 63499 invoked by uid 500); 21 Oct 2013 18:00:03 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 63418 invoked by uid 500); 21 Oct 2013 18:00:03 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 63405 invoked by uid 99); 21 Oct 2013 18:00:01 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Oct 2013 18:00:01 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 73ED81D3639; Mon, 21 Oct 2013 17:59:59 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6237464925214645966==" MIME-Version: 1.0 Subject: Re: Review Request 14576: NOT expression doesn't handle nulls correctly. From: "Jitendra Pandey" To: "Ashutosh Chauhan" Cc: "hive" , "Jitendra Pandey" Date: Mon, 21 Oct 2013 17:59:59 -0000 Message-ID: <20131021175959.25434.34770@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jitendra Pandey" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14576/ X-Sender: "Jitendra Pandey" References: <20131021081318.25434.32118@reviews.apache.org> In-Reply-To: <20131021081318.25434.32118@reviews.apache.org> Reply-To: "Jitendra Pandey" --===============6237464925214645966== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14576/ ----------------------------------------------------------- (Updated Oct. 21, 2013, 5:59 p.m.) Review request for hive and Ashutosh Chauhan. Changes ------- Updated patch to remove static mappings. The uploaded patch, doesn't include a small change in VectorMapJoinOperator.java because of some review board errors. The exact patch to be committed should be picked from the JIRA. Bugs: HIVE-5430 https://issues.apache.org/jira/browse/HIVE-5430 Repository: hive-git Description ------- NOT expression doesn't handle nulls correctly. Diffs (updated) ----- ant/src/org/apache/hadoop/hive/ant/GenVectorTestCode.java 4065067 ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticColumn.txt 2ab4aec ql/src/gen/vectorization/ExpressionTemplates/ColumnArithmeticScalar.txt 35890f8 ql/src/gen/vectorization/ExpressionTemplates/ColumnCompareColumn.txt 5ce261f ql/src/gen/vectorization/ExpressionTemplates/ColumnCompareScalar.txt e333224 ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryFunc.txt eed6ebe ql/src/gen/vectorization/ExpressionTemplates/ColumnUnaryMinus.txt dbcee4c ql/src/gen/vectorization/ExpressionTemplates/FilterColumnCompareColumn.txt 1c16816 ql/src/gen/vectorization/ExpressionTemplates/FilterColumnCompareScalar.txt bf02419 ql/src/gen/vectorization/ExpressionTemplates/FilterScalarCompareColumn.txt 9a1d741 ql/src/gen/vectorization/ExpressionTemplates/FilterStringColumnCompareColumn.txt 3625f44 ql/src/gen/vectorization/ExpressionTemplates/FilterStringColumnCompareScalar.txt 690dd3c ql/src/gen/vectorization/ExpressionTemplates/FilterStringScalarCompareColumn.txt 5ba7703 ql/src/gen/vectorization/ExpressionTemplates/ScalarArithmeticColumn.txt d9efbe7 ql/src/gen/vectorization/ExpressionTemplates/ScalarCompareColumn.txt 4a29724 ql/src/gen/vectorization/ExpressionTemplates/StringColumnCompareColumn.txt 401fa3c ql/src/gen/vectorization/ExpressionTemplates/StringColumnCompareScalar.txt a441d87 ql/src/gen/vectorization/ExpressionTemplates/StringScalarCompareColumn.txt 635b3e6 ql/src/gen/vectorization/TestTemplates/TestColumnScalarFilterVectorExpressionEvaluation.txt af30490 ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java 1f955d4 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExpressionDescriptor.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorFilterOperator.java 101ea28 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java f213ee8 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorReduceSinkOperator.java 55e11f8 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSelectOperator.java 5cbf618 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 79437a5 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedExpressions.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/AbstractFilterStringColLikeStringScalar.java d1b70ab ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java a6cde8e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColOrCol.java b57a844 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ConstantVectorExpression.java 119b4b9 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterColAndScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterColOrScalar.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterExprAndExpr.java e6b511d ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterExprOrExpr.java 703096c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterNotExpr.java cdf404c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterScalarAndColumn.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterScalarOrColumn.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColLikeStringScalar.java 2b54008 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FilterStringColRegExpStringScalar.java 92c46b3 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncLogWithBaseDoubleToDouble.java 214b6a5 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncLogWithBaseLongToDouble.java 42cb926 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncLongToString.java cb9d4d1 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncPowerDoubleToDouble.java dca4265 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncPowerLongToDouble.java 59e058c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRand.java 1a7fa2b ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/FuncRandNoSeed.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IdentityExpression.java 758cfcb ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNotNull.java 126090c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/IsNull.java 4a3f368 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongColumn.java 499b7df ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongColDivideLongScalar.java 461e632 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongScalarDivideLongColumn.java b37eafd ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/LongToStringUnaryUDF.java 3f3da00 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/NotCol.java 16c5805 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModDoubleToDouble.java 1ac8078 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/PosModLongToLong.java a9e0f7c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/RoundWithNumDigitsDoubleToDouble.java 54ffe69 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/SelectColumnIsFalse.java c92be99 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/SelectColumnIsNotNull.java 8dd232c ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/SelectColumnIsNull.java 81106ac ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/SelectColumnIsTrue.java f1ffc39 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColCol.java d09febb ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatColScalar.java c7ad347 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringConcatScalarCol.java 6e7579e ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringLength.java c7acc55 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringSubstrColStart.java 7a30534 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringSubstrColStartLen.java 6c21a38 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringUnaryUDF.java 8c2a348 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/StringUnaryUDFDirect.java bf65110 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorExpression.java 4239ec8 ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/VectorUDFTimestampFieldLong.java c19fd2a ql/src/java/org/apache/hadoop/hive/ql/exec/vector/udf/VectorUDFAdaptor.java 9716f88 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 3e6edb5 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAcos.java 9844ec8 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAsin.java f850790 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFAtan.java c4504bf ql/src/java/org/apache/hadoop/hive/ql/udf/UDFBin.java af394c4 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCeil.java 92c813d ql/src/java/org/apache/hadoop/hive/ql/udf/UDFCos.java 06bbc39 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayOfMonth.java c78ddf2 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDegrees.java 1546f4c ql/src/java/org/apache/hadoop/hive/ql/udf/UDFExp.java 35b0987 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFFloor.java 66a0478 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHex.java fdb4436 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFHour.java 92f1e94 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLTrim.java 78180af ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLength.java bcc9302 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLike.java c0a8116 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLn.java 0e11a6c ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog.java 6aa7f6a ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog10.java a6e7c5e ql/src/java/org/apache/hadoop/hive/ql/udf/UDFLog2.java 87c6d22 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFMinute.java cf1304c ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPDivide.java f6167d4 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMinus.java c4579f6 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMod.java bfa2da5 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPMultiply.java 0daaec5 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPNegative.java 5560cbf ql/src/java/org/apache/hadoop/hive/ql/udf/UDFOPPlus.java 49c66cb ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPosMod.java 49651ef ql/src/java/org/apache/hadoop/hive/ql/udf/UDFPower.java afee8f8 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRTrim.java da2f112 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRadians.java 484a926 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRand.java 71e59fb ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRegExp.java b6fe4ed ql/src/java/org/apache/hadoop/hive/ql/udf/UDFRound.java cfe4d84 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSecond.java 3d7b3eb ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSign.java 76b205f ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSin.java 25ac46a ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSqrt.java 6717e9d ql/src/java/org/apache/hadoop/hive/ql/udf/UDFSubstr.java e1272e9 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTan.java 9fe260a ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToBoolean.java b0921cd ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToByte.java 11408b3 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToDouble.java bc1be48 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToFloat.java 9d3ff0b ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToInteger.java 3498db5 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToLong.java 87c2288 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToShort.java 5a96723 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java 6a4272a ql/src/java/org/apache/hadoop/hive/ql/udf/UDFTrim.java 8e36ef5 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFWeekOfYear.java 7f087e0 ql/src/java/org/apache/hadoop/hive/ql/udf/UDFYear.java 0150cbd ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAbs.java 541adc1 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java 8d48799 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java 06edb14 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPAnd.java 689d855 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqual.java dc4670e ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrGreaterThan.java f44f353 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPEqualOrLessThan.java 7d74e82 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPGreaterThan.java 47fceb1 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPLessThan.java 12369a8 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNot.java e1f67ba ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotEqual.java 22b3bef ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNotNull.java c16eac3 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPNull.java 5efceea ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFOPOr.java 4dc95cc ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFTimestamp.java b145d31 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToUnixTimeStamp.java c1b2607 ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java 4b1bab6 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorFilterOperator.java c877cef ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 14b04c5 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorFilterExpressions.java 8321772 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java da67c63 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorMathFunctions.java b8330d9 ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorStringExpressions.java 917d7ef ql/src/test/queries/clientpositive/vectorization_0.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_1.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_10.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_11.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_12.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_13.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_14.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_15.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_16.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_2.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_3.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_4.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_5.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_6.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_7.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_8.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_9.q PRE-CREATION ql/src/test/queries/clientpositive/vectorization_not.q PRE-CREATION ql/src/test/results/clientpositive/vectorization_0.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_1.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_10.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_11.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_12.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_13.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_14.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_15.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_16.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_2.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_3.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_4.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_5.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_6.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_7.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_8.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_9.q.out PRE-CREATION ql/src/test/results/clientpositive/vectorization_not.q.out PRE-CREATION Diff: https://reviews.apache.org/r/14576/diff/ Testing ------- File Attachments ---------------- https://reviews.apache.org/media/uploaded/files/2013/10/21/HIVE-5430.6.patch Thanks, Jitendra Pandey --===============6237464925214645966==--