Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0DBE1F9E3 for ; Sat, 5 Oct 2013 02:50:01 +0000 (UTC) Received: (qmail 58956 invoked by uid 500); 5 Oct 2013 02:49:58 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 58884 invoked by uid 500); 5 Oct 2013 02:49:57 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 58861 invoked by uid 99); 5 Oct 2013 02:49:54 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 05 Oct 2013 02:49:54 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 8FBA01D2F36; Sat, 5 Oct 2013 02:49:53 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2569844908758601607==" MIME-Version: 1.0 Subject: Re: Review Request 14490: HIVE-5372: Refactor TypeInfo and PrimitiveTypeEntry class hierachy to eliminate info repetition From: "Jason Dere" To: "Ashutosh Chauhan" Cc: "Jason Dere" , "Xuefu Zhang" , "hive" Date: Sat, 05 Oct 2013 02:49:53 -0000 Message-ID: <20131005024953.28588.24570@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Jason Dere" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14490/ X-Sender: "Jason Dere" References: <20131004140717.28588.23316@reviews.apache.org> In-Reply-To: <20131004140717.28588.23316@reviews.apache.org> Reply-To: "Jason Dere" --===============2569844908758601607== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14490/#review26707 ----------------------------------------------------------- Nice, this looks much cleaner. I'll try to take another look later but overall this looks good changes. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java Here you might have to pass in the TypeInfo. Test out stuff like cast('abc' as varchar(10)) - if it's not done right then the TypeInfo for that expression shows up as varchar(3). serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharUtils.java Maybe this can be combined with ParameterizedPrimitiveTypeUtils, or those methods can be moved here since they are all varchar-specific now. - Jason Dere On Oct. 4, 2013, 2:07 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14490/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2013, 2:07 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-5372 > https://issues.apache.org/jira/browse/HIVE-5372 > > > Repository: hive-git > > > Description > ------- > > See JIRA comment https://issues.apache.org/jira/browse/HIVE-5372?focusedCommentId=13785506&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13785506 > > > Diffs > ----- > > contrib/src/java/org/apache/hadoop/hive/contrib/util/typedbytes/TypedBytesRecordReader.java 8fcb3b3 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java f8d1483 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java eb10360 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 628efab > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 36034d6 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java c8c5f63 > ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java af51072 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java 6538add > ql/src/java/org/apache/hadoop/hive/ql/udf/SettableUDF.java 9225aa1 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java 0ce1825 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java 366d9e6 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java 5ba2ec5 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java 509a392 > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java 1bb164a > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java 6815195 > serde/src/java/org/apache/hadoop/hive/serde2/RegexSerDe.java 5de5bd5 > serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java a206023 > serde/src/java/org/apache/hadoop/hive/serde2/dynamic_type/DynamicSerDe.java ac81ab8 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java 67f032c > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java 1286cba > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java 214a3e7 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/AbstractPrimitiveLazyObjectInspector.java 29c8528 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBinaryObjectInspector.java dbd60f7 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyBooleanObjectInspector.java 954f1d9 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyByteObjectInspector.java 57c5169 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyDateObjectInspector.java 679e5ea > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyDoubleObjectInspector.java 675333a > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyFloatObjectInspector.java 648b629 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveDecimalObjectInspector.java 564a1aa > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java e827e09 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyIntObjectInspector.java 81f6f05 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyLongObjectInspector.java 9455fbf > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java e28eef7 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyShortObjectInspector.java 78aba36 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyStringObjectInspector.java 2f31d18 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyTimestampObjectInspector.java cc68e4f > serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyVoidObjectInspector.java 019653a > serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java fb1b0ea > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java c711c62 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java 404ce78 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java 21947ff > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveJavaObjectInspector.java b2ae767 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveObjectInspector.java af4109b > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/AbstractPrimitiveWritableObjectInspector.java 16daf8f > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaBinaryObjectInspector.java 75a0cad > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaBooleanObjectInspector.java 97bfdac > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaByteObjectInspector.java 9c66a4c > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaDateObjectInspector.java e5b4582 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaDoubleObjectInspector.java 666033e > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaFloatObjectInspector.java 14db1ae > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveDecimalObjectInspector.java d330c5e > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java c2cf804 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaIntObjectInspector.java 6505080 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaLongObjectInspector.java eb96c63 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaShortObjectInspector.java ad82b4d > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaStringObjectInspector.java be7c64a > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaTimestampObjectInspector.java 2e8e266 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaVoidObjectInspector.java 6636aba > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java ac105d3 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java c74f24d > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java f6fe169 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableBinaryObjectInspector.java 3b20f9f > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableBooleanObjectInspector.java fe739ec > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableByteObjectInspector.java cfda1ef > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java f2b35f9 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableDateObjectInspector.java 7678c44 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableDoubleObjectInspector.java 6e6dee5 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableFloatObjectInspector.java 4efd91d > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveDecimalObjectInspector.java 8c9aedd > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java eea252c > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableIntObjectInspector.java a896c50 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableLongObjectInspector.java 7d8bc59 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableShortObjectInspector.java 60b63b2 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableStringObjectInspector.java c174a83 > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableTimestampObjectInspector.java 993223d > serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableVoidObjectInspector.java 19df45c > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseCharTypeInfo.java PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/BaseTypeParams.java 1eba561 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java 8a48349 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeInfo.java 40785cd > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/PrimitiveTypeSpec.java 6d8af3c > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java 05dbb81 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java 0ae4331 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeInfo.java PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java c602918 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharUtils.java PRE-CREATION > serde/src/test/org/apache/hadoop/hive/serde2/lazybinary/TestLazyBinarySerDe.java 954a4b8 > serde/src/test/org/apache/hadoop/hive/serde2/objectinspector/TestObjectInspectorConverters.java 421d11b > service/src/java/org/apache/hive/service/cli/TypeDescriptor.java 97bdcb1 > service/src/java/org/apache/hive/service/cli/TypeQualifiers.java dacb4ef > > Diff: https://reviews.apache.org/r/14490/diff/ > > > Testing > ------- > > Partially run tests. Waiting for pre-commit test to run. > > > Thanks, > > Xuefu Zhang > > --===============2569844908758601607==--