Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A76B710ACE for ; Wed, 2 Oct 2013 18:20:40 +0000 (UTC) Received: (qmail 70418 invoked by uid 500); 2 Oct 2013 18:20:39 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 70358 invoked by uid 500); 2 Oct 2013 18:20:39 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 70345 invoked by uid 99); 2 Oct 2013 18:20:38 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Oct 2013 18:20:38 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 9F5571D3402; Wed, 2 Oct 2013 18:20:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4885336996725609117==" MIME-Version: 1.0 Subject: Re: Review Request 14428: Migrate expression serialization to Kryo From: "Sergey Shelukhin" To: "hive" , "Ashutosh Chauhan" , "Sergey Shelukhin" Date: Wed, 02 Oct 2013 18:20:37 -0000 Message-ID: <20131002182037.28588.80222@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Sergey Shelukhin" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14428/ X-Sender: "Sergey Shelukhin" References: <20131002130734.28588.36395@reviews.apache.org> In-Reply-To: <20131002130734.28588.36395@reviews.apache.org> Reply-To: "Sergey Shelukhin" --===============4885336996725609117== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14428/#review26617 ----------------------------------------------------------- trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 10345... trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java the return type of the fn above has changed, this check seems useless trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java why is this needed? if needed, please add exception listener (see XMLDecoder APIs) trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java should this be removed? - Sergey Shelukhin On Oct. 2, 2013, 1:07 p.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14428/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 1:07 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5411 > https://issues.apache.org/jira/browse/HIVE-5411 > > > Repository: hive > > > Description > ------- > > Migrate expression serialization to Kryo > > > Diffs > ----- > > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HBaseStorageHandler.java 1528446 > trunk/hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizationContext.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/vector/udf/VectorUDFAdaptor.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexPredicateAnalyzer.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/IndexSearchCondition.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/index/compact/CompactIndexHandler.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStoragePredicateHandler.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteCanApplyProcFactory.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartExprEvalUtils.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionExpressionForMetastore.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDescUtils.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeGenericFuncDesc.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/ExprWalkerProcFactory.java 1528446 > trunk/ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java 1528446 > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestUtilities.java 1528446 > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorSelectOperator.java 1528446 > trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorizationContext.java 1528446 > trunk/ql/src/test/org/apache/hadoop/hive/ql/io/sarg/TestSearchArgumentImpl.java 1528446 > trunk/ql/src/test/results/compiler/plan/case_sensitivity.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/cast1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/groupby6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input20.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input8.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input9.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_part1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_testxpath.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/input_testxpath2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join7.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/join8.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample2.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample3.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample5.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/sample7.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/subq.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf1.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf4.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf6.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf_case.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/udf_when.q.xml 1528446 > trunk/ql/src/test/results/compiler/plan/union.q.xml 1528446 > > Diff: https://reviews.apache.org/r/14428/diff/ > > > Testing > ------- > > No new functionality. Improvement of existing functionality. Existing test case should suffice. > > > Thanks, > > Ashutosh Chauhan > > --===============4885336996725609117==--