hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5407) show create table creating unusable DDL when some reserved keywords exist
Date Tue, 08 Oct 2013 08:04:43 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13789025#comment-13789025
] 

Hive QA commented on HIVE-5407:
-------------------------------



{color:green}Overall{color}: +1 all checks pass

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12607268/HIVE-5407.1.patch

{color:green}SUCCESS:{color} +1 4061 tests passed

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1070/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1070/console

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
{noformat}

This message is automatically generated.

> show create table creating unusable DDL when some reserved keywords  exist
> --------------------------------------------------------------------------
>
>                 Key: HIVE-5407
>                 URL: https://issues.apache.org/jira/browse/HIVE-5407
>             Project: Hive
>          Issue Type: Bug
>          Components: CLI
>         Environment: hive 0.11
>            Reporter: Zhichun Wu
>            Priority: Minor
>         Attachments: D13191.1.patch, HIVE-5407.1.patch
>
>
> HIVE-701 already makes most reserved keywords available for table/column/partition names
and 'show create table' produces usable DDLs.
> However I think it's better if we quote table/column/partition names for the output of
'show create table', which is how mysql works and seems more robust.
> For example, use select as column name will produce unusable DDL:
> {code}
> create table table_select(`select` string);
> show create table table_select;
> {code}



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message