hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Edward Capriolo (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-5395) Various cleanup in ptf code
Date Wed, 02 Oct 2013 05:31:27 GMT

    [ https://issues.apache.org/jira/browse/HIVE-5395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13783671#comment-13783671
] 

Edward Capriolo commented on HIVE-5395:
---------------------------------------

IT would be nice to get this committed before it goes stale. This is mostly just check style
violations.

> Various cleanup in ptf code
> ---------------------------
>
>                 Key: HIVE-5395
>                 URL: https://issues.apache.org/jira/browse/HIVE-5395
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Edward Capriolo
>            Assignee: Edward Capriolo
>         Attachments: HIVE-5395.1.patch.txt, HIVE-5395.2.patch.txt, HIVE-5395.3.patch.txt,
HIVE-5395.4.patch.txt
>
>
> Some minor issues:
> Implementing classes on left side of equals
> Stack used instead of ArrayDeque
> Classes defined statically inside other files (when they do not need to be
> Checkstyle errors like indenting



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message