hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brock Noland <br...@cloudera.com>
Subject Re: Why aren't both HCatalog tests being updated?
Date Wed, 16 Oct 2013 17:40:33 GMT
It sounds like we are just forgetting. Please consider this a friendly
reminder to update both tests if you are fixing some environmental or
bug in the tests.

On Wed, Oct 16, 2013 at 12:36 PM, Eugene Koifman
<ekoifman@hortonworks.com> wrote:
> I don't have a good answer for this
>
>
> On Wed, Oct 16, 2013 at 9:58 AM, Brock Noland <brock@cloudera.com> wrote:
>
>> Agreed, but notice that the changes I reference are fixes for tests.
>> Why wouldn't they be replicated?
>>
>> Example:
>>
>>
>> https://github.com/apache/hive/blob/trunk/hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitionPublish.java#L160
>>
>> https://github.com/apache/hive/blob/trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatPartitionPublish.java#L153
>>
>> Example:
>>
>>
>> https://github.com/apache/hive/blob/trunk/hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java#L122
>>
>> https://github.com/apache/hive/blob/trunk/hcatalog/webhcat/java-client/src/test/java/org/apache/hcatalog/api/TestHCatClient.java#L125
>>
>> On Wed, Oct 16, 2013 at 11:55 AM, Eugene Koifman
>> <ekoifman@hortonworks.com> wrote:
>> > As a general rule, everything in org.apache.hcatalog is deprecated and
>> > frozen at 0.11 version.  All new features/bug fixes should be made in
>> > org.apache.hive.hcatalog.
>> >
>> >
>> > On Wed, Oct 16, 2013 at 7:52 AM, Brock Noland <brock@cloudera.com>
>> wrote:
>> >
>> >> Hi,
>> >>
>> >> I've noticed a number of cases where one HCatalog test is modified but
>> >> the deprecated "pair" is not. Are we just forgetting or is this on
>> >> purpose?
>> >>
>> >> Example:
>> >>
>> >>
>> >>
>> https://github.com/apache/hive/blob/trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatPartitionPublish.java#L153
>> >>
>> >>
>> https://github.com/apache/hive/blob/trunk/hcatalog/core/src/test/java/org/apache/hcatalog/mapreduce/TestHCatPartitionPublish.java#L153
>> >>
>> >> Example:
>> >>
>> >>
>> >>
>> https://github.com/apache/hive/blob/trunk/hcatalog/webhcat/java-client/src/test/java/org/apache/hive/hcatalog/api/TestHCatClient.java#L122
>> >>
>> >>
>> https://github.com/apache/hive/blob/trunk/hcatalog/webhcat/java-client/src/test/java/org/apache/hcatalog/api/TestHCatClient.java#L125
>> >>
>> >> Brock
>> >>
>> >
>> > --
>> > CONFIDENTIALITY NOTICE
>> > NOTICE: This message is intended for the use of the individual or entity
>> to
>> > which it is addressed and may contain information that is confidential,
>> > privileged and exempt from disclosure under applicable law. If the reader
>> > of this message is not the intended recipient, you are hereby notified
>> that
>> > any printing, copying, dissemination, distribution, disclosure or
>> > forwarding of this communication is strictly prohibited. If you have
>> > received this communication in error, please contact the sender
>> immediately
>> > and delete it from your system. Thank You.
>>
>>
>>
>> --
>> Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org
>>
>
> --
> CONFIDENTIALITY NOTICE
> NOTICE: This message is intended for the use of the individual or entity to
> which it is addressed and may contain information that is confidential,
> privileged and exempt from disclosure under applicable law. If the reader
> of this message is not the intended recipient, you are hereby notified that
> any printing, copying, dissemination, distribution, disclosure or
> forwarding of this communication is strictly prohibited. If you have
> received this communication in error, please contact the sender immediately
> and delete it from your system. Thank You.



-- 
Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org

Mime
View raw message