hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V" <go...@hortonworks.com>
Subject Review Request 15097: Remove .array() assumptions from ORC RecordReaderImpl and InStream
Date Wed, 30 Oct 2013 14:49:56 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15097/
-----------------------------------------------------------

Review request for hive and Owen O'Malley.


Bugs: HIVE-5663
    https://issues.apache.org/jira/browse/HIVE-5663


Repository: hive-git


Description
-------

This patch scrubs all ByteBuffer.wrap assumptions from the RecordReaderImpl and InStream classes.

The code still uses wrapped bytebuffers in the read path, but accesses all data using the
ByteBuffer methods without resorting to .array() data.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/io/orc/InStream.java 3164a19 
  ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 71484a3 

Diff: https://reviews.apache.org/r/15097/diff/


Testing
-------

tested with TestORCFile, -Dtestcase=TestCliDriver -Dqfile_regex=.*orc.*


Thanks,

Gopal V


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message