hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brock Noland" <br...@cloudera.com>
Subject Re: Review Request 14651: HIVE-5543 - Running the mini tez cluster for tez unit tests
Date Tue, 29 Oct 2013 15:12:06 GMT


> On Oct. 29, 2013, 9:48 a.m., Vikram Dixit Kumaraswamy wrote:
> > ql/build.xml, line 138
> > <https://reviews.apache.org/r/14651/diff/1/?file=364830#file364830line138>
> >
> >     I will do it. Just to understand though, does this affect mavenization or is
an aesthetic concern?

I don't see how whitespace could affect mavenization? :)

It's an aesthetic concern, but something that should be addressed. We should not commit trailing
whitespace whenever possible, that is why it shows up in red.

Thanks guys!


- Brock


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14651/#review27559
-----------------------------------------------------------


On Oct. 15, 2013, 9:50 p.m., Vikram Dixit Kumaraswamy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14651/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 9:50 p.m.)
> 
> 
> Review request for hive and Gunther Hagleitner.
> 
> 
> Bugs: HIVE-5543
>     https://issues.apache.org/jira/browse/HIVE-5543
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Running the mini tez cluster for tez unit tests.
> 
> 
> Diffs
> -----
> 
>   build-common.xml ee6a3ce 
>   build.properties 3dbd33f 
>   hbase-handler/src/test/org/apache/hadoop/hive/hbase/HBaseQTestUtil.java 0558048 
>   hbase-handler/src/test/templates/TestHBaseCliDriver.vm 191bbc7 
>   hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm e6bd211 
>   ql/build.xml be8e10f 
>   ql/ivy.xml d0159d9 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java cee95fd 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java 1726da6 
>   ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java ddcc544 
>   ql/src/test/org/apache/hadoop/hive/ql/TestLocationQueries.java 0ddc1d5 
>   ql/src/test/queries/clientpositive/tez_join_tests.q PRE-CREATION 
>   ql/src/test/queries/clientpositive/tez_joins_explain.q PRE-CREATION 
>   ql/src/test/results/clientpositive/tez_join_tests.q.out PRE-CREATION 
>   ql/src/test/results/clientpositive/tez_joins_explain.q.out PRE-CREATION 
>   ql/src/test/templates/TestCliDriver.vm f2623f8 
>   ql/src/test/templates/TestNegativeCliDriver.vm 7159faf 
>   ql/src/test/templates/TestParse.vm e28e901 
>   ql/src/test/templates/TestParseNegative.vm 1aec083 
>   shims/build.xml cbfba5a 
>   shims/src/0.23/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 6368395 
>   shims/src/common/java/org/apache/hadoop/hive/shims/ShimLoader.java a4714ae 
>   shims/src/tez/java/org/apache/hadoop/hive/shims/TezShims.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14651/diff/
> 
> 
> Testing
> -------
> 
> Added new tests for running the tez mini cluster and a new test target.
> 
> 
> Thanks,
> 
> Vikram Dixit Kumaraswamy
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message