hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Xuefu Zhang" <xzh...@cloudera.com>
Subject Re: Review Request 14985: HIVE-5354: Decimal precision/scale support in ORC file
Date Mon, 28 Oct 2013 19:38:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14985/#review27632
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java
<https://reviews.apache.org/r/14985/#comment53683>

    This is a valid concern. However, there is no way to "preserve" previous precision/scale,
as previously precision is always 38, and scale is variable while here we need to re-fit it
to a precision and a fixed scale. I think a default one, (38, 18), may satisfy (most of cases).
What do you think?


- Xuefu Zhang


On Oct. 28, 2013, 4:49 a.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14985/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2013, 4:49 a.m.)
> 
> 
> Review request for hive and Brock Noland.
> 
> 
> Bugs: HIVE-5354
>     https://issues.apache.org/jira/browse/HIVE-5354
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Support decimal precision/scale for Orc file, as part of HIVE-3976.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcStruct.java c993b37 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/RecordReaderImpl.java 71484a3 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 7519fc1 
>   ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto 53b93a0 
> 
> Diff: https://reviews.apache.org/r/14985/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message