hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Harish Butani" <rhbut...@gmail.com>
Subject Re: Review Request 14856: HIVE-5552: Merging of QBJoinTrees doesn't handle filter pushdowns correctly
Date Thu, 24 Oct 2013 18:18:28 GMT


> On Oct. 24, 2013, 3:57 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java, line 1397
> > <https://reviews.apache.org/r/14856/diff/1/?file=369330#file369330line1397>
> >
> >     I am bit confused. Is it tablename.colname or colname ? Looks like former for
test cases you added, so how come we are able to determine correct index for it in joinTree.baseSrc
list, since that I presume will only contain table aliases?

this gets handled by a recursive call in checkJoinFilterRefersOneAlias


- Harish


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14856/#review27457
-----------------------------------------------------------


On Oct. 24, 2013, 6:16 p.m., Harish Butani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14856/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 6:16 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Bugs: HIVE-5552
>     https://issues.apache.org/jira/browse/HIVE-5552
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> Merging of QBJoinTrees doesn't handle filter pushdowns correctly
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 12a0a69 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java 9834e73 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java c886760 
>   ql/src/test/queries/clientpositive/join_merging.q PRE-CREATION 
>   ql/src/test/results/clientpositive/join_merging.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14856/diff/
> 
> 
> Testing
> -------
> 
> ran all join tests.
> added join_merging.q test
> 
> 
> Thanks,
> 
> Harish Butani
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message