hive-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasad Mujumdar" <pras...@cloudera.com>
Subject Re: Review Request 14523: HIVE-5486 HiveServer2 should create base scratch directories at startup
Date Wed, 09 Oct 2013 05:12:06 GMT


> On Oct. 8, 2013, 9:30 p.m., Brock Noland wrote:
> > Hi Prasad,
> > 
> > I think this is a good change. There is one item below that might need resolving?

Thanks Brock!
Addressed the comments will update the patch


> On Oct. 8, 2013, 9:30 p.m., Brock Noland wrote:
> > service/src/java/org/apache/hive/service/cli/CLIService.java, line 85
> > <https://reviews.apache.org/r/14523/diff/2/?file=362071#file362071line85>
> >
> >     userVars contains
> >     
> >       /**
> >        * The conf variables that depends on current user
> >        */
> >       public static final HiveConf.ConfVars[] userVars = {
> >         HiveConf.ConfVars.SCRATCHDIR,
> >         HiveConf.ConfVars.LOCALSCRATCHDIR,
> >         HiveConf.ConfVars.DOWNLOADED_RESOURCES_DIR,
> >         HiveConf.ConfVars.HIVEHISTORYFILELOC
> >       };
> >     
> >     
> >     Do the other two need to be configured as well?

yes, I think DOWNLOADED_RESOURCES_DIR should be created. The hive history is disabled by default
and not useful for HiveServer2. That should be left out. Thanks for catching that.


> On Oct. 8, 2013, 9:30 p.m., Brock Noland wrote:
> > service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java,
line 142
> > <https://reviews.apache.org/r/14523/diff/2/?file=362072#file362072line142>
> >
> >     userVars is unused after this change.

right. Removed


- Prasad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14523/#review26797
-----------------------------------------------------------


On Oct. 8, 2013, 1:34 a.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14523/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2013, 1:34 a.m.)
> 
> 
> Review request for hive.
> 
> 
> Bugs: HIVE-5486
>     https://issues.apache.org/jira/browse/HIVE-5486
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> With impersonation enabled, the same base directory is used by all sessions/queries.
For a new deployment, this directory gets created on first invocation by the user running
that session. This would cause directory permission conflict for other users.
> The patch is creating base scratch dirs at startup if it doesn't exist.
> 
> 
> Diffs
> -----
> 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 1a7f338 
>   service/src/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java ae7bb6b

>   service/src/test/org/apache/hive/service/cli/TestEmbeddedThriftBinaryCLIService.java
da325da 
>   service/src/test/org/apache/hive/service/cli/TestScratchDir.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/14523/diff/
> 
> 
> Testing
> -------
> 
> Added new test
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message