Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A9B8110BE8 for ; Mon, 16 Sep 2013 02:06:52 +0000 (UTC) Received: (qmail 7235 invoked by uid 500); 16 Sep 2013 02:06:52 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 7193 invoked by uid 500); 16 Sep 2013 02:06:52 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 7184 invoked by uid 500); 16 Sep 2013 02:06:52 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 7181 invoked by uid 99); 16 Sep 2013 02:06:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Sep 2013 02:06:52 +0000 Date: Mon, 16 Sep 2013 02:06:52 +0000 (UTC) From: "Phabricator (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-5276) Skip useless string encoding stage for hiveserver2 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-5276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13768001#comment-13768001 ] Phabricator commented on HIVE-5276: ----------------------------------- cwsteinbach has commented on the revision "HIVE-5276 [jira] Skip useless string encoding stage for hiveserver2". INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/ListSinkOperator.java:57 Let's get rid of this comment and anything special we're doing for Hadoop 0.17. We deprecated support for that version a long time ago. service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java:98 I admit that I haven't investigated this closely, but the fact that we're overriding a user-configurable property with a hardcoded value seems like a red flag. If this is genuinely necessary can you please add a comment explaining the rationale? Thanks. ql/src/java/org/apache/hadoop/hive/ql/exec/DefaultFetchConverter.java:50 We deprecated support for 0.17 and 0.18 a long time ago. Please remove. common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:667 Please add this to conf/hive-default.xml.template along with a template explaining what it does. Also, is this something that we really want to expose to users at this point in time? REVISION DETAIL https://reviews.facebook.net/D12879 To: JIRA, navis Cc: cwsteinbach > Skip useless string encoding stage for hiveserver2 > -------------------------------------------------- > > Key: HIVE-5276 > URL: https://issues.apache.org/jira/browse/HIVE-5276 > Project: Hive > Issue Type: Improvement > Components: HiveServer2 > Reporter: Navis > Assignee: Navis > Priority: Minor > Attachments: HIVE-5276.D12879.1.patch > > > Current hiveserver2 acquires rows in string format which is used for cli output. Then convert them into row again and convert to final format lastly. This is inefficient and memory consuming. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira