Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Fri, 6 Sep 2013 18:43:52 +0000 (UTC)
From: "Thejas M Nair (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12667274.1378457088306.93452.1378493032390@arcas>
In-Reply-To: <JIRA.12667274.1378457088306@arcas>
References: <JIRA.12667274.1378457088306@arcas>
Subject: [jira] [Updated] (HIVE-5236) Change HCatalog spacing from 4 spaces
 to 2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HIVE-5236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thejas M Nair updated HIVE-5236:
--------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

Patch committed to trunk. Thanks Sushanth for jumping on this! Makes life better for anybody contributing to hcat !

                
> Change HCatalog spacing from 4 spaces to 2
> ------------------------------------------
>
>                 Key: HIVE-5236
>                 URL: https://issues.apache.org/jira/browse/HIVE-5236
>             Project: Hive
>          Issue Type: Bug
>          Components: HCatalog
>    Affects Versions: 0.12.0
>            Reporter: Sushanth Sowmyan
>            Assignee: Sushanth Sowmyan
>             Fix For: 0.12.0
>
>         Attachments: HIVE-5236.patch, test_output_after_spacing_changes
>
>
> Now that we went around changing hcatalog package to be inside hive with HIVE-4869, one of the remaining sore points is that hcatalog standardizes on 4 spaces for its indenting style, and hive standardizes on 2 spaces for its indenting style. This causes headaches for those of us who have to edit parts of both.
> We've thus far not bothered changing them because we didn't want to lose modification history for hcatalog, but due to the svn mv we had to do, we've already lost that battle. So, we might as well go ahead and do this.
> I'm also creating this as a separate patch because I don't want to expand the scope of HIVE-4869 which is complex enough. If we agree to do this, we should do this soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira