Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 23 Sep 2013 22:28:05 +0000 (UTC)
From: "Ashutosh Chauhan (JIRA)" <jira@apache.org>
To: hive-dev@hadoop.apache.org
Message-ID: <JIRA.12666789.1378251467979.5454.1379975285312@arcas>
In-Reply-To: <JIRA.12666789.1378251467979@arcas>
References: <JIRA.12666789.1378251467979@arcas>
Subject: [jira] [Commented] (HIVE-5202) Support for
 SettableUnionObjectInspector and implement isSettable/hasAllFieldsSettable
 APIs for all data types.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-5202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775728#comment-13775728 ] 

Ashutosh Chauhan commented on HIVE-5202:
----------------------------------------

+1 As a further optimization if both table and partition has same serde than we don't even need to check for OI conversions, since its serde from which OI is obtained. Lets do this in a follow-up jira.
                
> Support for SettableUnionObjectInspector and implement isSettable/hasAllFieldsSettable APIs for all data types.
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-5202
>                 URL: https://issues.apache.org/jira/browse/HIVE-5202
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-5202.2.patch.txt, HIVE-5202.patch
>
>
> These 3 tasks should be accomplished as part of the following jira:
> 1. The current implementation lacks settable union object inspector. We can run into exception inside ObjectInspectorConverters.getConvertedOI() if there is a union.
> 2. Implement the following public functions for all datatypes: 
> isSettable()-> Perform shallow check to see if an object inspector is inherited from settableOI type and 
> hasAllFieldsSettable() -> Perform deep check to see if this objectInspector and all the underlying object inspectors are inherited from settableOI type.
> 3. ObjectInspectorConverters.getConvertedOI() is inefficient. Once (1) and (2) are implemented, add the following check: outputOI.hasAllSettableFields() should be added to return outputOI immediately if the object is entirely settable in order to prevent redundant object instantiation.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira