Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 83678101A4 for ; Tue, 24 Sep 2013 01:51:03 +0000 (UTC) Received: (qmail 80669 invoked by uid 500); 24 Sep 2013 01:51:03 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 80623 invoked by uid 500); 24 Sep 2013 01:51:03 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 80614 invoked by uid 500); 24 Sep 2013 01:51:03 -0000 Delivered-To: apmail-hadoop-hive-dev@hadoop.apache.org Received: (qmail 80611 invoked by uid 99); 24 Sep 2013 01:51:03 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Sep 2013 01:51:03 +0000 Date: Tue, 24 Sep 2013 01:51:02 +0000 (UTC) From: "Sergey Shelukhin (JIRA)" To: hive-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-5181) RetryingRawStore should not retry on logical failures (e.g. from commit) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-5181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13775916#comment-13775916 ] Sergey Shelukhin commented on HIVE-5181: ---------------------------------------- Nice. You can retry open though, right? > RetryingRawStore should not retry on logical failures (e.g. from commit) > ------------------------------------------------------------------------ > > Key: HIVE-5181 > URL: https://issues.apache.org/jira/browse/HIVE-5181 > Project: Hive > Issue Type: Bug > Reporter: Sergey Shelukhin > Assignee: Prasad Mujumdar > Priority: Minor > Attachments: HIVE-5181.1.patch > > > RetryingRawStore retries calls. Some method (e.g. drop_table_core in HiveMetaStore) explicitly call openTransaction and commitTransaction on RawStore. > When the commit call fails due to some real issue, it is retried, and instead of a real cause for failure one gets some bogus exception about transaction open count. > I doesn't make sense to retry logical errors, especially not from commitTransaction. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira