Mailing-List: contact dev-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Content-Type: multipart/alternative;
 boundary="===============5839157706815372238=="
MIME-Version: 1.0
Subject: Re: Review Request 14155: HIVE-5297 Hive does not honor type for
 partition
 columns
From: "Vikram Dixit Kumaraswamy" <vikram.dixit@gmail.com>
To: "Ashutosh Chauhan" <hashutosh@apache.org>
Cc: "Harish Butani" <rhbutani@gmail.com>, "hive" <dev@hive.apache.org>,
 "Vikram Dixit Kumaraswamy" <vikram.dixit@gmail.com>,
 "Sergey Shelukhin" <sergey@hortonworks.com>,
 "Hari Sankar Sivarama Subramaniyan" <hsubramaniyan@hortonworks.com>
Date: Thu, 26 Sep 2013 18:55:13 -0000
Message-ID: <20130926185513.1616.59389@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Vikram Dixit Kumaraswamy" <noreply@reviews.apache.org>
References: <20130925202245.1616.30311@reviews.apache.org>
In-Reply-To: <20130925202245.1616.30311@reviews.apache.org>
Reply-To: "Vikram Dixit Kumaraswamy" <vikram.dixit@gmail.com>

--===============5839157706815372238==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14155/
-----------------------------------------------------------

(Updated Sept. 26, 2013, 6:55 p.m.)


Review request for hive and Ashutosh Chauhan.


Changes
-------

Fix failing test.


Bugs: HIVE-5297
    https://issues.apache.org/jira/browse/HIVE-5297


Repository: hive-git


Description
-------

Hive does not consider the type of the partition column while writing partitions. Consider for example the query:

create table tab1 (id1 int, id2 string) PARTITIONED BY(month string,day int) row format delimited fields terminated by ',';
alter table tab1 add partition (month='June', day='second');

Hive accepts this query. However if you try to select from this table and insert into another expecting schema match, it will insert nulls instead.


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 350c348 
  ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 393ef57 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java a704462 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 0c01749 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 767f545 
  ql/src/test/queries/clientnegative/illegal_partition_type.q PRE-CREATION 
  ql/src/test/queries/clientnegative/illegal_partition_type2.q PRE-CREATION 
  ql/src/test/queries/clientpositive/alter_partition_coltype.q 4d2e02f 
  ql/src/test/queries/clientpositive/partition_type_check.q PRE-CREATION 
  ql/src/test/results/clientnegative/alter_table_add_partition.q.out bd9c148 
  ql/src/test/results/clientnegative/alter_view_failure5.q.out 4edb82c 
  ql/src/test/results/clientnegative/illegal_partition_type.q.out PRE-CREATION 
  ql/src/test/results/clientnegative/illegal_partition_type2.q.out PRE-CREATION 
  ql/src/test/results/clientpositive/alter_partition_coltype.q.out fe16fdd 
  ql/src/test/results/clientpositive/partition_type_check.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/14155/diff/


Testing
-------

Ran all tests.


Thanks,

Vikram Dixit Kumaraswamy


--===============5839157706815372238==--