Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6841810AA8 for ; Tue, 24 Sep 2013 22:18:59 +0000 (UTC) Received: (qmail 56418 invoked by uid 500); 24 Sep 2013 22:18:54 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 56240 invoked by uid 500); 24 Sep 2013 22:18:50 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 56196 invoked by uid 99); 24 Sep 2013 22:18:49 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Sep 2013 22:18:49 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id CE5391D2F76; Tue, 24 Sep 2013 22:18:37 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6607724160700188608==" MIME-Version: 1.0 Subject: Re: Review Request 14243: HIVE-5325: Implement statistics providing ORC writer and reader interfaces From: j.prasanth.j@gmail.com To: "Owen O'Malley" , "Ashutosh Chauhan" Cc: "hive" , j.prasanth.j@gmail.com Date: Tue, 24 Sep 2013 22:18:37 -0000 Message-ID: <20130924221837.1617.88734@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: noreply@reviews.apache.org X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14243/ X-Sender: noreply@reviews.apache.org References: <20130920012412.31250.62860@reviews.apache.org> In-Reply-To: <20130920012412.31250.62860@reviews.apache.org> Reply-To: j.prasanth.j@gmail.com --===============6607724160700188608== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14243/ ----------------------------------------------------------- (Updated Sept. 24, 2013, 10:18 p.m.) Review request for hive, Ashutosh Chauhan and Owen O'Malley. Changes ------- Refreshed the patch after HIVE-5324 changes. Bugs: HIVE-5325 https://issues.apache.org/jira/browse/HIVE-5325 Repository: hive-git Description ------- HIVE-5324 adds new interfaces that can be implemented by ORC reader/writer to provide statistics. Writer provided statistics is used to update table/partition level statistics in metastore. Reader provided statistics can be used for reducer estimation, CBO etc. in the absence of metastore statistics. Diffs (updated) ----- ql/src/java/org/apache/hadoop/hive/ql/io/orc/BinaryColumnStatistics.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/io/orc/ColumnStatisticsImpl.java 6268617 ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcOutputFormat.java c80fb02 ql/src/java/org/apache/hadoop/hive/ql/io/orc/ReaderImpl.java c454f32 ql/src/java/org/apache/hadoop/hive/ql/io/orc/StringColumnStatistics.java 72e779a ql/src/java/org/apache/hadoop/hive/ql/io/orc/WriterImpl.java 44961ce ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java PRE-CREATION ql/src/protobuf/org/apache/hadoop/hive/ql/io/orc/orc_proto.proto edbf822 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 34b2305 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcFile.java e6569f4 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcNullOptimization.java b93db84 ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcSerDeStats.java PRE-CREATION ql/src/test/resources/orc-file-dump-dictionary-threshold.out 003c132 ql/src/test/resources/orc-file-dump.out fac5326 Diff: https://reviews.apache.org/r/14243/diff/ Testing ------- ORC related unit and qfile tests are passing. Thanks, Prasanth_J --===============6607724160700188608==--