Return-Path: X-Original-To: apmail-hive-dev-archive@www.apache.org Delivered-To: apmail-hive-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 770DF10979 for ; Fri, 20 Sep 2013 14:24:38 +0000 (UTC) Received: (qmail 92810 invoked by uid 500); 20 Sep 2013 14:24:36 -0000 Delivered-To: apmail-hive-dev-archive@hive.apache.org Received: (qmail 92738 invoked by uid 500); 20 Sep 2013 14:24:35 -0000 Mailing-List: contact dev-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list dev@hive.apache.org Received: (qmail 92714 invoked by uid 99); 20 Sep 2013 14:24:33 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Sep 2013 14:24:33 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F12211D33B9; Fri, 20 Sep 2013 14:24:29 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============2939643283637221301==" MIME-Version: 1.0 Subject: Re: Review Request 14221: HIVE-4113: Optimize select count(1) with RCFile and Orc From: "Yin Huai" To: "Yin Huai" , "hive" , "Ashutosh Chauhan" Date: Fri, 20 Sep 2013 14:24:29 -0000 Message-ID: <20130920142429.3518.97356@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Yin Huai" X-ReviewGroup: hive X-ReviewRequest-URL: https://reviews.apache.org/r/14221/ X-Sender: "Yin Huai" References: <20130920031848.31250.60155@reviews.apache.org> In-Reply-To: <20130920031848.31250.60155@reviews.apache.org> Reply-To: "Yin Huai" --===============2939643283637221301== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14221/ ----------------------------------------------------------- (Updated Sept. 20, 2013, 2:24 p.m.) Review request for hive. Changes ------- added missing imports... Bugs: HIVE-4113 https://issues.apache.org/jira/browse/HIVE-4113 Repository: hive-git Description ------- Modifies ColumnProjectionUtils such there are two flags. One for the column ids and one indicating whether all columns should be read. Additionally the patch updates all locations which uses the old method of empty string indicating all columns should be read. The automatic formatter generated by ant eclipse-files is fairly aggressive so there are some unrelated import/whitespace cleanup. This one is based on https://reviews.apache.org/r/11770/ and has been rebased to the latest trunk. Diffs (updated) ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 9f37d0c conf/hive-default.xml.template 545026d hbase-handler/src/java/org/apache/hadoop/hive/hbase/HiveHBaseTableInputFormat.java 766056b hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/HCatBaseInputFormat.java 553446a hcatalog/core/src/test/java/org/apache/hive/hcatalog/mapreduce/TestHCatPartitioned.java 577e06d hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestHCatLoader.java d38bb8d ql/src/java/org/apache/hadoop/hive/ql/Driver.java 31a52ba ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java df2ccf1 ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java ab0494e ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java a5a8943 ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java 0f29a0e ql/src/java/org/apache/hadoop/hive/ql/io/BucketizedHiveInputFormat.java 49145b7 ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java cccdc1b ql/src/java/org/apache/hadoop/hive/ql/io/RCFile.java a83f223 ql/src/java/org/apache/hadoop/hive/ql/io/RCFileRecordReader.java 9521060 ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 50c5093 ql/src/java/org/apache/hadoop/hive/ql/optimizer/ColumnPrunerProcFactory.java ed14e82 ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java b97d869 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/MetadataOnlyOptimizer.java 0550bf6 ql/src/test/org/apache/hadoop/hive/ql/io/PerformTestRCFileAndSeqFile.java fb9fca1 ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java dd1276d ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 83c5c38 serde/src/java/org/apache/hadoop/hive/serde2/ColumnProjectionUtils.java 0b3ef7b serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarSerDe.java 11f5f07 serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarStruct.java 1335446 serde/src/java/org/apache/hadoop/hive/serde2/columnar/ColumnarStructBase.java e1270cc serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarSerDe.java b717278 serde/src/java/org/apache/hadoop/hive/serde2/columnar/LazyBinaryColumnarStruct.java 0317024 serde/src/test/org/apache/hadoop/hive/serde2/TestColumnProjectionUtils.java PRE-CREATION Diff: https://reviews.apache.org/r/14221/diff/ Testing ------- Thanks, Yin Huai --===============2939643283637221301==--